From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEEFC432C0 for ; Mon, 2 Dec 2019 01:12:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97E1C2146E for ; Mon, 2 Dec 2019 01:12:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EUU2rUlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97E1C2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibaGP-0004u8-Q8 for qemu-devel@archiver.kernel.org; Sun, 01 Dec 2019 20:12:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49822) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibaFi-0004Rr-DL for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:11:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibaFh-0004B3-7x for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:11:50 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:38481) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibaFh-00049o-1k for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:11:49 -0500 Received: by mail-pg1-x544.google.com with SMTP id t3so17064934pgl.5 for ; Sun, 01 Dec 2019 17:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KbjuFww7zuB3fL/Fbz84eOXxjpPoBRs5MDedHKSbw8k=; b=EUU2rUlLoAeaAb+/YYMuyfE4Cqv3AGJgn197qYGt6DUrXacuKb7nqx3qt226FteO1o 2w77f60ZNSml5VrltHjhVf07C31J9OoAvnV/JjnEysgV9//Rot/OjaAxellv5s7g2y0N V6Phneh7JzVu9Y4HJihnbjvpCMaL6tGJ/la0yxq0+qiOv1Klg2J9RSybyLnaD8YwMPJB zWjocISgqukUmecpN3B56pznnOetAPNxdO8/QpBvjDOMvt1NVD0zCyx8AuTGx4wUGLsK 1Mu7nXqMNF4IEumFwB8bhrOmcvVd6rMFigMuc4hxn/BP4i7K9VKrvWdDHY3ZLPnuU9cO lJJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KbjuFww7zuB3fL/Fbz84eOXxjpPoBRs5MDedHKSbw8k=; b=l9LiZTnd/Q9TODXKqLg/IzxeXTCo7/kPcBDZ1BogJWOfllnIL4i1Ymcrhg0nY26UpU 96cJcz0B5GWIOTpPQ28tZT1PA6pYDMak9ahYLFlO8nyvAIZTAUB3AxKMNyukDCIA1PlX E65UWPQ2SkdBENCJ/iuHCMFpZCn5HufylkDyz4DVdLpsysNJXe+Xz+bM3peK7Y8FXubg 9W4H12LDmaPhGv9jBoqLrSw1uiEqCPdH8o37iTJRvl6oWde5JOh8FLNU3zFbBXQ1R1iF 4r1ArX1Qb9K7h7u2FA+rEYMC1CPLw0B/hjDAWvlaThCqXUoKp8sfH6Py0jY5NglCGB+t UORw== X-Gm-Message-State: APjAAAWZO+YATsFikHV4u1FHlMnctOnihJi5VK3mDJumgw3/FMUhul0C 5EYhcrwWscIC+P9BV4V2QIdjuQ== X-Google-Smtp-Source: APXvYqyfYAIJ2LAM+luSBSP2bOMpGmqFbLF77MBF0kXztokUWrUYtAyzpEWhQDp6/JQFWR5AJ2g9ZQ== X-Received: by 2002:a63:214e:: with SMTP id s14mr2257930pgm.428.1575249107496; Sun, 01 Dec 2019 17:11:47 -0800 (PST) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id in19sm12012715pjb.11.2019.12.01.17.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Dec 2019 17:11:46 -0800 (PST) Subject: Re: [PATCH v1 2/5] linux-user: convert target_mmap debug to tracepoint To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20191128194603.24818-1-alex.bennee@linaro.org> <20191128194603.24818-3-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <44a30f10-a215-daa7-a8a4-0b0a1564a65e@linaro.org> Date: Sun, 1 Dec 2019 17:11:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191128194603.24818-3-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/28/19 7:46 PM, Alex Bennée wrote: > + if (TRACE_TARGET_MMAP_ENABLED) { > + char prot_str[4]; > + g_autoptr(GString) flag_str = g_string_new(NULL); > + > + pp_prot(&prot_str, prot); > + > + if (flags & MAP_FIXED) { > + g_string_append(flag_str, "MAP_FIXED "); > + } > + if (flags & MAP_ANONYMOUS) { > + g_string_append(flag_str, "MAP_ANON "); > + } > + > + switch (flags & MAP_TYPE) { > case MAP_PRIVATE: > - printf("MAP_PRIVATE "); > + g_string_append(flag_str, "MAP_PRIVATE "); > break; > case MAP_SHARED: > - printf("MAP_SHARED "); > + g_string_append(flag_str, "MAP_SHARED "); > break; > default: > - printf("[MAP_TYPE=0x%x] ", flags & MAP_TYPE); > + g_string_append_printf(flag_str, "[MAP_TYPE=0x%x] ", > + flags & MAP_TYPE); > break; > } > - printf("fd=%d offset=" TARGET_ABI_FMT_lx "\n", fd, offset); > + trace_target_mmap(start, len, prot_str, flag_str->str, fd, offset); > } I don't think that you need to re-create -strace output. There are also quite a lot of MAP_* flags that are not being printed, without any indication that they are left out. Again, I think we should just print the hex value. r~