From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test across to gitlab
Date: Tue, 10 Nov 2020 12:23:27 -0200 [thread overview]
Message-ID: <44f0215b-6328-8593-6a8a-d26b3804703f@redhat.com> (raw)
In-Reply-To: <20201108204535.2319870-9-philmd@redhat.com>
On 11/8/20 6:45 PM, Philippe Mathieu-Daudé wrote:
> Similarly to commit 8cdb2cef3f1, move the linux-user (debug-tcg)
> test to GitLab.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Laurent Vivier <laurent@vivier.eu>
> ---
> .gitlab-ci.yml | 7 +++++++
> .travis.yml | 9 ---------
> 2 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3fc3d0568c6..80082a602b8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -304,6 +304,13 @@ build-user:
> CONFIGURE_ARGS: --disable-tools --disable-system
> MAKE_CHECK_ARGS: check-tcg
>
> +build-user-debug:
> + <<: *native_build_job_definition
> + variables:
> + IMAGE: debian-all-test-cross
> + CONFIGURE_ARGS: --disable-tools --disable-system --enable-debug-tcg
> + MAKE_CHECK_ARGS: check-tcg
> +
It would be useful a variable like 'MAKE_BUILD_ARGS' so that we could
overwrite the default make target (as in the diff below). So that here
it would eval to `make -j"$JOBS" build-tcg` as is done in Travis CI.
On the absence of such as variable,
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3b15ae5c30..27517afd22 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -34,7 +34,7 @@ include:
else
../configure --enable-werror $CONFIGURE_ARGS ;
fi || { cat config.log meson-logs/meson-log.txt && exit 1; }
- - make -j"$JOBS"
+ - make -j"$JOBS" "$MAKE_BUILD_ARGS"
- if test -n "$MAKE_CHECK_ARGS";
then
make -j"$JOBS" $MAKE_CHECK_ARGS ;
> # Run check-tcg against linux-user (with plugins)
> # we skip sparc64-linux-user until it has been fixed somewhat
> # we skip cris-linux-user as it doesn't use the common run loop
> diff --git a/.travis.yml b/.travis.yml
> index 15d92291358..bee6197290d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -293,15 +293,6 @@ jobs:
> - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread" || { cat config.log meson-logs/meson-log.txt && exit 1; }
>
>
> - # Run check-tcg against linux-user
> - - name: "GCC check-tcg (user)"
> - env:
> - - CONFIG="--disable-system --enable-debug-tcg"
> - - TEST_BUILD_CMD="make build-tcg"
> - - TEST_CMD="make check-tcg"
> - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
> -
> -
> # Run check-tcg against softmmu targets
> - name: "GCC check-tcg (some-softmmu)"
> env:
next prev parent reply other threads:[~2020-11-10 14:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 20:45 [PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server Philippe Mathieu-Daudé
2020-11-09 8:34 ` Thomas Huth
2020-11-08 20:45 ` [PATCH-for-5.2 v4 02/17] meson: always include contrib/libvhost-user Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-5.2 v4 03/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 04/17] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section Philippe Mathieu-Daudé
2020-11-09 10:06 ` Thomas Huth
2020-11-09 19:29 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled Philippe Mathieu-Daudé
2020-11-09 20:57 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options Philippe Mathieu-Daudé
2020-11-09 10:16 ` Thomas Huth
2020-11-08 20:45 ` [PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab Philippe Mathieu-Daudé
2020-11-09 10:20 ` Thomas Huth
2020-11-09 11:04 ` Philippe Mathieu-Daudé
2020-11-09 11:18 ` Thomas Huth
2020-11-09 13:02 ` Philippe Mathieu-Daudé
2020-11-10 13:44 ` Wainer dos Santos Moschetta
2020-11-10 14:01 ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test " Philippe Mathieu-Daudé
2020-11-10 14:23 ` Wainer dos Santos Moschetta [this message]
2020-11-10 19:34 ` Alex Bennée
2020-11-08 20:45 ` [PATCH-for-6.0 v4 09/17] gitlab-ci: Move gprof/gcov " Philippe Mathieu-Daudé
2020-11-10 15:03 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 10/17] gitlab-ci: Move user-static " Philippe Mathieu-Daudé
2020-11-10 15:06 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 11/17] gitlab-ci: Move tools-only and softfloat tests " Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 12/17] gitlab-ci: Move coroutine " Philippe Mathieu-Daudé
2020-11-09 9:42 ` Stefan Hajnoczi
2020-11-10 17:15 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 13/17] tests/docker: Install lttng-ust-devel package in Fedora image Philippe Mathieu-Daudé
2020-11-09 9:42 ` Stefan Hajnoczi
2020-11-10 17:29 ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 14/17] gitlab-ci: Move trace backend tests across to gitlab Philippe Mathieu-Daudé
2020-11-09 9:48 ` Stefan Hajnoczi
2020-11-10 18:12 ` Wainer dos Santos Moschetta
2020-11-11 8:42 ` Philippe Mathieu-Daudé
2020-11-11 8:45 ` Philippe Mathieu-Daudé
2020-11-11 8:50 ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7) Philippe Mathieu-Daudé
2020-11-26 17:38 ` Anthony PERARD via
2020-11-26 17:45 ` Eduardo Habkost
2020-11-27 14:24 ` Anthony PERARD via
2020-11-30 21:28 ` Stefano Stabellini
2020-11-08 20:45 ` [PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional Philippe Mathieu-Daudé
2020-11-08 22:00 ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 17/17] gitlab-ci: Make MIPS user-mode 32-bit little-endian job optional Philippe Mathieu-Daudé
2020-11-10 15:55 ` [PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI Alex Bennée
2020-11-10 16:07 ` Philippe Mathieu-Daudé
2020-12-09 11:06 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f0215b-6328-8593-6a8a-d26b3804703f@redhat.com \
--to=wainersm@redhat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).