From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: "Nikolay Shirokovskiy" <nshirokovskiy@virtuozzo.com>,
"Peter Krempa" <pkrempa@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt
Date: Thu, 18 Jul 2019 15:52:01 +0200 [thread overview]
Message-ID: <4620eddd-e500-25d2-a8b2-5c47eefc74ab@redhat.com> (raw)
In-Reply-To: <20190718134537.22356-1-den@openvz.org>
On 18/07/19 15:45, Denis V. Lunev wrote:
> There are the following flags available in libvirt inside cpu_map.xm
> <feature name='cvt16'>
> <cpuid function='0x80000001' ecx='0x00040000'/>
> </feature>
> <feature name='cmt'> <!-- cqm -->
> <cpuid eax_in='0x07' ecx_in='0x00' ebx='0x00001000'/>
> </feature>
> We have faced the problem that QEMU does not start once these flags are
> present in the domain.xml.
>
> This patch just adds proper names into the map.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: Eduardo Habkost <ehabkost@redhat.com>
> CC: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> CC: Peter Krempa <pkrempa@redhat.com>
> CC: Daniel P. Berrangé <berrange@redhat.com>
> ---
> target/i386/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 805ce95247..88ba4dad47 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -870,7 +870,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> "lahf-lm", "cmp-legacy", "svm", "extapic",
> "cr8legacy", "abm", "sse4a", "misalignsse",
> "3dnowprefetch", "osvw", "ibs", "xop",
> - "skinit", "wdt", NULL, "lwp",
> + "skinit", "wdt", "cvt16", "lwp",
> "fma4", "tce", NULL, "nodeid-msr",
> NULL, "tbm", "topoext", "perfctr-core",
> "perfctr-nb", NULL, NULL, NULL,
> @@ -1044,7 +1044,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> "fsgsbase", "tsc-adjust", NULL, "bmi1",
> "hle", "avx2", NULL, "smep",
> "bmi2", "erms", "invpcid", "rtm",
> - NULL, NULL, "mpx", NULL,
> + "cmt", NULL, "mpx", NULL,
> "avx512f", "avx512dq", "rdseed", "adx",
> "smap", "avx512ifma", "pcommit", "clflushopt",
> "clwb", "intel-pt", "avx512pf", "avx512er",
>
Oops, nice catch! I've queued the patch for 4.1.
Paolo
next prev parent reply other threads:[~2019-07-18 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 13:45 [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt Denis V. Lunev
2019-07-18 13:52 ` Paolo Bonzini [this message]
2019-07-19 13:00 ` Denis V. Lunev
2019-07-19 20:53 ` Eduardo Habkost, Denis V. Lunev
2019-07-19 21:44 ` Paolo Bonzini
2019-07-19 22:05 ` Eduardo Habkost
2019-07-19 22:16 ` Paolo Bonzini
2019-08-14 11:36 ` Jiri Denemark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4620eddd-e500-25d2-a8b2-5c47eefc74ab@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).