From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D68C432C1 for ; Tue, 24 Sep 2019 19:54:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFC6D2146E for ; Tue, 24 Sep 2019 19:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFC6D2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqsw-0003gM-Kl for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 15:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqqd-0001wt-6f for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCqqb-00010z-3z for qemu-devel@nongnu.org; Tue, 24 Sep 2019 15:51:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46532) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCqqW-0000zu-Q2; Tue, 24 Sep 2019 15:51:37 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B1F1A26687; Tue, 24 Sep 2019 19:51:36 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9F3519C58; Tue, 24 Sep 2019 19:51:35 +0000 (UTC) Subject: Re: [PATCH 0/2] enhance iotest 223 coverage To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" References: <20190924143522.22902-1-eblake@redhat.com> <8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <473f7df2-9845-d90e-6dc9-0542ec2c3c76@redhat.com> Date: Tue, 24 Sep 2019 14:51:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X59CdbfxiZxjiJtUWT5fFvjVfdRTa4ZEH" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Tue, 24 Sep 2019 19:51:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "nsoffer@redhat.com" , "qemu-block@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X59CdbfxiZxjiJtUWT5fFvjVfdRTa4ZEH Content-Type: multipart/mixed; boundary="RcKB7nvaGwz7X72jadwk1PK9QqJGSHpio"; protected-headers="v1" From: Eric Blake To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" Cc: "nsoffer@redhat.com" , "qemu-block@nongnu.org" Message-ID: <473f7df2-9845-d90e-6dc9-0542ec2c3c76@redhat.com> Subject: Re: [PATCH 0/2] enhance iotest 223 coverage References: <20190924143522.22902-1-eblake@redhat.com> <8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com> In-Reply-To: <8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com> --RcKB7nvaGwz7X72jadwk1PK9QqJGSHpio Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/24/19 2:26 PM, Vladimir Sementsov-Ogievskiy wrote: > 24.09.2019 17:35, Eric Blake wrote: >> Commit 506902c6 dropped non-iothread coverage in order to test iothrea= d, >> better is to run things twice. In doing this, I found it easier to >> edit the test when the log shows what commands were triggering various= >> responses. >=20 > Did you consider adding -iothread to tests/qemu-iotests/check instead, = to be > able to run any (or some) tests with or without iothread? I don't know how many of the existing iotests would benefit from the ability supply iothread as an option, nor how likely it is that someone would actually remember to run the testsuite twice to cover the use of that option. I also don't know how hard it would be to retrofit the addition of optional iothread support into all the tests. Rather, I addressed the more immediate concern of the fact that my recent addition to using iothread in 223 lost the previous ability of that test to cover non-iothread, and where this patch series now makes it cover both scenarios with a single iotests run. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --RcKB7nvaGwz7X72jadwk1PK9QqJGSHpio-- --X59CdbfxiZxjiJtUWT5fFvjVfdRTa4ZEH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl2Kc8YACgkQp6FrSiUn Q2pOBgf/XoZM+BYgmmQ25ueC8+FqBAhn7CyGsYUUphQn6ktoro8ROR48f4x+AI/C 8zaEw+BxhSjMC6YD29FWImHxRiHGJ9jAh41UNUxzPbWDZ6XpKXKBH8qHrpFuN+0V Xg+Nmo6JkBiqnchravFYwBn724CDAgq9nCKW42/iBcxnhjvpjHiL67u2rEYXKz6/ mc5B6PEz7OhktnZbtWgKtk2PnOUkik/93PhhU/a+drhV8yt3hZdQjDX5CY3f2y7h 9824voK0YrxNl27cU50XfLVX50Z63FnCbNeGmc9MijGH1rbxFzSKbPPkIn2BwARM Ex16Htxj5l9qmuIXhZCHSwlPTWO+XA== =PkQN -----END PGP SIGNATURE----- --X59CdbfxiZxjiJtUWT5fFvjVfdRTa4ZEH--