qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hyman Huang <huangy81@chinatelecom.cn>
To: Thomas Huth <thuth@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	berrange@redhat.com
Cc: qemu-devel <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] tests/migration: fix parameter of auto-converge migration
Date: Wed, 24 Mar 2021 14:03:52 +0800	[thread overview]
Message-ID: <4745b145-9678-a09c-be7b-bb1d9b4e6263@chinatelecom.cn> (raw)
In-Reply-To: <58fd7151-f026-ca82-9818-8156083398db@redhat.com>



在 2021/3/24 13:42, Thomas Huth 写道:
> On 23/03/2021 20.40, Dr. David Alan Gilbert wrote:
>> * huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
>>> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>>
>>> when execute the following test command:
>>> $ ./guestperf-batch.py --auto-converge \
>>>      --auto-converge-step {percent} ...
>>> test aborts and error message be throwed as the following:
>>> "Parameter 'x-cpu-throttle-increment' is unexpected"
>>>
>>> The reason is that 'x-cpu-throttle-increment' has been
>>> deprecated and 'cpu-throttle-increment' was introduced
>>> Since v2.7. Use the new parameter instead.
>>>
>>> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>
>> Please cc thuth@redhat.com and berrange@redhat.com on fixes to this
>> file.
> 
> This not really my turf, since it's not directly related to the qtests.
> 
> But I wonder why tests/migration/ is not listed in the "Migration" 
> sections in the MAINTAINERS file ... care to send a patch?

the following patch aim to do this, it's already reviewed and has not 
been merged yet.

https://patchew.org/QEMU/91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn/

> 
>   Thomas
> 

-- 
Best regard

Hyman Huang(黄勇)


  reply	other threads:[~2021-03-24  6:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 15:43 [PATCH] tests/migration: fix parameter of auto-converge migration huangy81
2021-03-23 19:40 ` Dr. David Alan Gilbert
2021-03-24  5:42   ` Thomas Huth
2021-03-24  6:03     ` Hyman Huang [this message]
2021-04-06 17:05 ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4745b145-9678-a09c-be7b-bb1d9b4e6263@chinatelecom.cn \
    --to=huangy81@chinatelecom.cn \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).