From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8A2CA9EA1 for ; Fri, 18 Oct 2019 13:17:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA8F621925 for ; Fri, 18 Oct 2019 13:17:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="L/MvreJl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA8F621925 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLS8c-0004Hw-1f for qemu-devel@archiver.kernel.org; Fri, 18 Oct 2019 09:17:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49112) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLS6e-0002i7-NI for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:15:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLS6d-0005Yi-Fp for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:15:48 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:36441) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLS6c-0005W4-Tj for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:15:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=Kp4HYJDHNEKmOJfuEN8/j/a9aK4OYU5hQ6PcyIRX6GI=; b=L/MvreJl8y3ll1JRYWw76UPUyi Bp88td0NxmdYmikTXm5VhUAnAd0w07fC9BxIrMo9EME4SMh7xOJS0JpQxm3GTj6TDX1lN4rRTQqCg 2XsoKx9XQT7sye7HrMDGgWB4aDSUJKdjV8//1OUfDjM0ZUTBjmCb6ANBc0HwLZb901ptM7QLcRD4u JGmPne9vxAX3MLByHU1+VA4BixipitHkaYCoa72+CZ4ZWKdAHmL6fzvUl9zCtls84aAsM68kMyE3k EXoIZ/3znD9ItUOcVE+khBiWsCdycCbHW8Qj89BNMMw1YXN/eCWE5GOA0tHb+ppkgE35TRM3sAm4J WXQBYy75heBMx7ZNm6m1Bva/GiTC8vPlv5lfhNGY0Y/fSBZouygUdIa1GQZxXFGd2b8oghTcr7G3L ZWsU7yLd8PW1ndWHyFSVhjPsEWnsWIWKmmPJBrlj5Z5GY7MsyGcM2/Hkw7FOLUPrsYnTWYQengxzy ZpmpGzA6Zf9C9GRDizc0pXOdsqxt7v0+ycpdoTsS6MRCi8QLYBbPTOGrIIO51atUWNVgY3UAon4UY mEHv5oSTBfBM7QeCHp63wWWTV1Pylrhjzwt9Gp4tPcQ3Ewp+b/qySabl/XkSzC3aeU54GeZRp6sDo RH67uClnDiR6jyVWWpUkHlPH8AGRmct1T4/589t+c=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , Christian Schoenebeck , Stefan Hajnoczi , Daniel =?ISO-8859-1?Q?P=2E_Berrang=E9?= , Antonios Motakis , Greg Kurz Subject: Re: virtio-fs: Fix file ID collisions (was: 9p: Fix file ID collisions) Date: Fri, 18 Oct 2019 15:15:43 +0200 Message-ID: <4866803.EgEq5jnlfW@silver> In-Reply-To: <20191016134409.GG2978@work-vm> References: <4114483.KuMf1QML1b@silver> <20191016134409.GG2978@work-vm> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.189.157.229 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mittwoch, 16. Oktober 2019 15:44:09 CEST Dr. David Alan Gilbert wrote: > > > Unless I'm missing something, it seems that "virtio-fs" has the same > > > issue we had on 9pfs before Christian's patches... :-\ > > > > Is a fix for this desired for virtio-fs? > > Yes I think so; we had originally thought we were hiding the host inode > numbers; but that's not true - since we pass both a device and inode > number in virtiofs, unlike 9p, it seems we can probably get away with > only remapping device IDs rather than inode numbers; but that requires > some understanding of how multiple block device IDs are supposed to look > like to the guest kernel. Postponed on my side then. My original idea was simply sharing the existing inode remapping code from 9p. But remapping/adding device ids on guest side like you suggested is cleaner; takes more time though to lookup the required kernel interfaces to achieve that. Best regards, Christian Schoenebeck