From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: den@openvz.org, marcandre.lureau@redhat.com,
vsementsov@virtuozzo.com, berrange@redhat.com, berto@igalia.com
Subject: Re: [Qemu-devel] [PATCH v4 0/2] char-socket: Fix race condition
Date: Wed, 21 Aug 2019 10:18:42 +0200 [thread overview]
Message-ID: <4883fb10-5863-f260-5698-90b3a5e0a00c@redhat.com> (raw)
In-Reply-To: <1565625509-404969-1-git-send-email-andrey.shinkevich@virtuozzo.com>
On 12/08/19 17:58, Andrey Shinkevich wrote:
> This fixes a race condition in which the tcp_chr_read() ioc handler
> can close a connection that is being written to from another thread.
>
> v4:
> The functions qemu_idle_add() and tcp_chr_be_event_closed() were removed
> because the callback is invoked after the call to object_property_del_all()
> so, the "chardev" object had been deleted and the segmentation fault occurs.
> Let's please apply the Alberto's simplified series to avoid the race condition.
>
> v3:
> See the email thread with the Message ID
> <cover.1550842915.git.berto@igalia.com>
>
> Alberto Garcia (2):
> main-loop: Fix GSource leak in qio_task_thread_worker()
> char-socket: Lock tcp_chr_disconnect()
>
> chardev/char-socket.c | 16 +++++++++++++---
> io/task.c | 1 +
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
Queued, thanks.
Paolo
next prev parent reply other threads:[~2019-08-21 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 15:58 [Qemu-devel] [PATCH v4 0/2] char-socket: Fix race condition Andrey Shinkevich
2019-08-12 15:58 ` [Qemu-devel] [PATCH v4 1/2] main-loop: Fix GSource leak in qio_task_thread_worker() Andrey Shinkevich
2019-08-12 15:58 ` [Qemu-devel] [PATCH v4 2/2] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() Andrey Shinkevich
2019-08-20 9:58 ` Daniel P. Berrangé
2019-08-20 11:10 ` Andrey Shinkevich
2019-08-21 8:18 ` Paolo Bonzini [this message]
2019-08-21 9:51 ` [Qemu-devel] [PATCH v4 0/2] char-socket: Fix race condition Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4883fb10-5863-f260-5698-90b3a5e0a00c@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).