From: Laurent Vivier <laurent@vivier.eu>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
qemu-block@nongnu.org, "Thomas Huth" <huth@tuxfamily.org>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh
Date: Sat, 26 Oct 2019 18:47:09 +0200 [thread overview]
Message-ID: <489fbfef-ffb5-dc3e-949e-52e041285bee@vivier.eu> (raw)
In-Reply-To: <6dd7dbbb-dc48-7705-3865-e8a7bed75394@redhat.com>
Le 25/10/2019 à 16:01, Paolo Bonzini a écrit :
> On 22/10/19 13:17, Laurent Vivier wrote:
>> + if (s->dma_memory_read) {
>> + s->dma_memory_read(s->dma_opaque, &s->cmdbuf[s->cmdlen], len);
>> + } else {
>> + set_pdma(s, CMD, s->cmdlen, len);
>> + s->pdma_cb = do_dma_pdma_cb;
>> + esp_raise_drq(s);
>> + return;
>> + }
>> + trace_esp_handle_ti_cmd(s->cmdlen);
>> + s->ti_size = 0;
>> + s->cmdlen = 0;
>> + s->do_cmd = 0;
>> + do_cmd(s, s->cmdbuf);
>> return;
>
> Can you explain these lines after s->dma_memory_read? I suppose they
> are related to
>
>> - }
>> - if (s->do_cmd) {
>> + } else if (s->do_cmd) {
>
> If so, it would be nice to make those a separate patch. Otherwise seems
> okay.
Sent a new series with separate patches for ESP.
Could you have a look?
Thanks,
Laurent
next prev parent reply other threads:[~2019-10-26 16:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 11:17 [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 1/9] esp: add pseudo-DMA as used by Macintosh Laurent Vivier
2019-10-22 12:21 ` Philippe Mathieu-Daudé
2019-10-22 13:07 ` Laurent Vivier
2019-10-26 16:26 ` Laurent Vivier
2019-10-25 14:01 ` Paolo Bonzini
2019-10-25 14:54 ` Philippe Mathieu-Daudé
2019-10-25 15:07 ` Laurent Vivier
2019-10-26 16:47 ` Laurent Vivier [this message]
2019-10-22 11:17 ` [PATCH v14 2/9] dp8393x: manage big endian bus Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 3/9] hw/m68k: add VIA support Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 4/9] hw/m68k: implement ADB bus support for via Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 5/9] hw/m68k: add Nubus support Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 6/9] hw/m68k: add Nubus macfb video card Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 7/9] hw/m68k: add a dummy SWIM floppy controller Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 8/9] hw/m68k: define Macintosh Quadra 800 Laurent Vivier
2019-10-22 11:17 ` [PATCH v14 9/9] BootLinuxConsoleTest: Test the " Laurent Vivier
2019-10-22 19:02 ` [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489fbfef-ffb5-dc3e-949e-52e041285bee@vivier.eu \
--to=laurent@vivier.eu \
--cc=aurelien@aurel32.net \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).