From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7086AC433ED for ; Fri, 7 May 2021 16:29:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D25B76024A for ; Fri, 7 May 2021 16:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D25B76024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf3Lw-0007IR-Mf for qemu-devel@archiver.kernel.org; Fri, 07 May 2021 12:29:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf3KS-0006iP-4v for qemu-devel@nongnu.org; Fri, 07 May 2021 12:27:52 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:38609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf3KP-0006VU-Pz for qemu-devel@nongnu.org; Fri, 07 May 2021 12:27:51 -0400 Received: by mail-pf1-x42c.google.com with SMTP id k19so7990554pfu.5 for ; Fri, 07 May 2021 09:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=THFSOnFfkfiLCWh0lsl5vzF7ByYALWOnmVco5icXboo=; b=KEi1lPNUxgy5y7CjAM70v7J2rwUqlrtCcHuWGgVMwmse16ks3HiDh0XOHsgHhXxWlf gQA/kVEg6piFvZSQv+GvZ+Cd1euCekWDeZOKoGPo3Sg+mrFuoKWZTcTyDWTiqa6EuyvM KBRgywOX1O3+QqtyHA2eVnVm3bZldM6eIJzCNiL4OC/FWz0ggezjyfBV+Sk8r69SXVAP Ms59lrEKkaD8eD6vhhjjSEIRfegSaPe5SIWcBnWUoOcoHv9qHG9GpuzytWItsNZnTt1M QQfBbCSUaUzHVI/VoMQWHWjLQ8OanzOgakBAKZ4HPFFXJEpPHiL7uU5RrT/wY0xYbPKt 6o7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=THFSOnFfkfiLCWh0lsl5vzF7ByYALWOnmVco5icXboo=; b=FMvS6L90b+kBcujHq6BKCC/XN8h/Gos586nCw7IUeMha8d/5PU0sfFJl4cp+5z/OMb ktAP8gD8wdjRm35ecQqpfw37S8RXqny+xMfQfU5l1Eb/s69Qt3YqbbrwpDL587qU1Y+k oBDkWa9FLRXoFx7GX+xKgANVAZxcjhOiuhcQwtbJUAuYsQ1PKUT08NA/xe6cQkBXPjP4 P2xTKYVjmGA1V05QYRDZkKkSJKBMoFiFJJUi1aG2XThh29w9lAmxFjtJOfDdlJNxi6H0 b/XoyFbDgY+3OOge1ySur7xtdvs1tZKl3gMaa2QxjltMv46rVTDWRUwqx+Orb6gsxiae GZGA== X-Gm-Message-State: AOAM530bEsQz8wqbd+6UENxzQmrv2IMQQ9jIBjyzxRZPlgPE0V4GJnSV I9MQm2pMJ3cACEkgPPXMsspMZw== X-Google-Smtp-Source: ABdhPJzB0tzXfhuerAO6T/r0zGbfi2nGrR3h2LNY8UZ2cm0pESUWAm82NxLVd142yzVe0k+eO1SONQ== X-Received: by 2002:a65:40cc:: with SMTP id u12mr4787776pgp.158.1620404868124; Fri, 07 May 2021 09:27:48 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id 14sm5163140pfj.29.2021.05.07.09.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 May 2021 09:27:47 -0700 (PDT) Subject: Re: [PATCH 12/23] hw/i386/multiboot: Avoid dynamic stack allocation To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210505211047.1496765-1-philmd@redhat.com> <20210505211047.1496765-13-philmd@redhat.com> From: Richard Henderson Message-ID: <4908055a-fc2c-f2a8-7d2e-d5539f59d77b@linaro.org> Date: Fri, 7 May 2021 09:27:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210505211047.1496765-13-philmd@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-ppc@nongnu.org, Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/5/21 2:10 PM, Philippe Mathieu-Daudé wrote: > Use autofree heap allocation instead of variable-length array on > the stack. Replace the snprintf() call by g_strdup_printf(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/multiboot.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~