From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_IMAGE_ONLY_20,HTML_MESSAGE, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF69CC433B4 for ; Fri, 30 Apr 2021 15:57:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DDE5613ED for ; Fri, 30 Apr 2021 15:57:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DDE5613ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcVWJ-0005R1-5s for qemu-devel@archiver.kernel.org; Fri, 30 Apr 2021 11:57:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcVUw-0003v1-2Y for qemu-devel@nongnu.org; Fri, 30 Apr 2021 11:56:10 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:37612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcVUt-00034C-Ij for qemu-devel@nongnu.org; Fri, 30 Apr 2021 11:56:09 -0400 Received: by mail-qk1-x733.google.com with SMTP id t17so42664281qkg.4 for ; Fri, 30 Apr 2021 08:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=2I7MhnhFDXeBr9l6HPYDzdWjfdkPS7Q5DRF5ootVzNA=; b=BNntTL58erEpl0GACiUHqqf24oMPyA+yKeSBLimpgaggnrGHPYxi/brdLN8zLKPu3z VTeABAbuwP7s/oP8fpqNbueShFMxyJqS1xahHbbZWgbFVcuX3a1a72sZfsmVwD2TlsxS ssU+g4Fc/luPhslgBZOB62An7s/58pLkcX4hpakX1JPLU4WFnVxQ/Lm+VSV4blo715k7 noFZ70EbjrV/6Gr3KUQUhZVRWJAybdRVXdbKiXmbQZ1LPVipY5AaTKs7lTv/7H6lMZyJ jDMLjjBugwDfoTNFIWgIA0FA7zhsFqnG4/bQIYK7vcHafFOA6M3q44JujbsHvb3kKP+j eGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=2I7MhnhFDXeBr9l6HPYDzdWjfdkPS7Q5DRF5ootVzNA=; b=P3H70dsvvy8K08WuMpjKzjJ8MOEw9S/3nybJHmgL3L+VJ5eBusMyRfcMMNsaC6vQl8 LJoiU8MoZNbuDfN8raO+Oh0p6keNkyLF7x9ee4WHqa7PZpa2wylkZ1FIZiSL+XkeRRW8 7CHgBV/Umig4FaZxCmw5jcbrhJf5KqKW5Hl0puv6REw9e9KTNcZFFNvaD2EO4xJODiAQ cNGlJ9pEn1w+QP+mJZXNdD7SVSXEYV7J7fneo+sqYg3I8tFynG3bc2O3xcLoVeUjsxNw wo3vOMKA7bkuk6nI2XpRWBqvWn4A5GwYP6tPaiKxxCQ62GGxqZ3U6O83XSqO5asZvTmm Jh3w== X-Gm-Message-State: AOAM531NK/Y/cLZk2MJtCfxWda5arogUEILsm/oHuu9z3RXVjoGrTjl0 YgChcl8jQoouqT9GeRpSioMV/9DXO5UUJw== X-Google-Smtp-Source: ABdhPJx7+4fLbxuLzoUIzCGF0XyJcvlKymq7OwyB1x8KfIxdzSQn8i+BPEJlGwYBiuX1ZvGRja9RTA== X-Received: by 2002:a05:620a:1657:: with SMTP id c23mr5979833qko.264.1619798164527; Fri, 30 Apr 2021 08:56:04 -0700 (PDT) Received: from localhost.localdomain (bras-base-stsvon1503w-grc-23-174-92-28-28.dsl.bell.ca. [174.92.28.28]) by smtp.gmail.com with ESMTPSA id a21sm1763024qkk.45.2021.04.30.08.56.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Apr 2021 08:56:04 -0700 (PDT) Date: Fri, 30 Apr 2021 11:56:00 -0400 From: Shashi Mallela To: Peter Maydell Message-ID: <4B93C023-32E5-468F-80A8-DF58C8CD442F@getmailspring.com> In-Reply-To: References: Subject: Re: [PATCH v2 1/8] hw/intc: GICv3 ITS initial framework X-Mailer: Mailspring MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="608c2890_3c7f7cc7_12a1" Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=shashi.mallela@linaro.org; helo=mail-qk1-x733.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leif Lindholm , QEMU Developers , qemu-arm , Radoslaw Biernacki Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --608c2890_3c7f7cc7_12a1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Have taken care of it.please ignore PIDR2 changes in the current patchset ,will update the latest changes in the next patchset version Thanks Shashi On Apr 30 2021, at 6:09 am, Peter Maydell wrote: > On Fri, 30 Apr 2021 at 00:36, wrote: > > > > On Fri, 2021-04-16 at 18:21 +0100, Peter Maydell wrote: > > > On Thu, 1 Apr 2021 at 03:41, Shashi Mallela < > > > shashi.mallela@linaro.org> wrote: > > > > +#define GITS_PIDR2 0xFFE8 > > > > > > You probably don't want an offset for GITS_PIDR2 specifically. > > > Compare handling of GICD_IDREGS in the distributor emulation. > > > Tried re-using the GICD_IDREGS offset for GITS_PIDR2,but from testing > > > observed that the linux kernel driver and kvm-unit-tests both relied > > > on using the 0xFFE8 offset instead of 0xFFD0 (used by GICD & GICR) to > > > complete ITS initialization and setup > > I didn't mean "just put PIDR2 at the GICD_IDREGS offset", which > obviously won't work, I meant "implement the whole set of ID registers > (of which PIDR2 is one in the middle) in the same way we implement that > set on the other GIC components". > > -- PMM --608c2890_3c7f7cc7_12a1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Have taken care of it.please ignore PIDR2 changes in the current pat= chset  ,will update the latest changes in the next patchset version<= /div>
Thanks
Shashi

On Apr 30 2021, at 6:09 am, Peter Maydell <peter.= maydell=40linaro.org> wrote:
On =46ri, 30 A= pr 2021 at 00:36, <shashi.mallela=40linaro.org> wrote:
&g= t;
> On =46ri, 2021-04-16 at 18:21 +0100, Peter Maydell wrot= e:
> > On Thu, 1 Apr 2021 at 03:41, Shashi Mallela <
> > shashi.mallela=40linaro.org> wrote:
> = > > +=23define GITS=5FPIDR2 0x=46=46E8
> >
> > You probably don't want an offset for GITS=5FPIDR2 specifical= ly.
> > Compare handling of GICD=5FIDREGS in the distribu= tor emulation.
> > Tried re-using the GICD=5FIDREGS offse= t for GITS=5FPIDR2,but from testing
> > observed that the= linux kernel driver and kvm-unit-tests both relied
> > o= n using the 0x=46=46E8 offset instead of 0x=46=46D0 (used by GICD & G= ICR) to
> > complete ITS initialization and setup
I didn't mean =22just put PIDR2 at the GICD=5FIDREGS offset=22, wh= ich
obviously won't work, I meant =22implement the whole set of= ID registers
(of which PIDR2 is one in the middle) in the same= way we implement that
set on the other GIC components=22.
-- PMM
3D=22Sent --608c2890_3c7f7cc7_12a1--