From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>,
qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc <qemu-ppc@nongnu.org>
Subject: Re: [PATCH] ppc: remove excessive logging
Date: Sun, 15 Dec 2019 06:08:28 +0100 [thread overview]
Message-ID: <4a608af2-62a2-3ffb-0c02-8e0ca699d586@redhat.com> (raw)
In-Reply-To: <20191214121347.17071-1-joakim.tjernlund@infinera.com>
Hi Joakim,
I'm cc'ing the PPC maintainers for you, so they won't miss your patch
(see
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
and the output of ./scripts/get_maintainer.pl -f target/ppc/excp_helper.c).
On 12/14/19 1:13 PM, Joakim Tjernlund wrote:
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
>
> ppc logs every type of Invalid instruction. This generates a lot
> of garbage on console when sshd/ssh_keygen executes as
> they try various insn to optimize its performance.
> The invalid operation log is still there so an unknown insn
> will still be logged.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> ---
>
> As far as I can see, ppc is the only one emiting thsi
> debug msg for Invalid insns.
>
> target/ppc/excp_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 50b004d00d..45c2fa3ff9 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -326,7 +326,6 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
> env->spr[SPR_BOOKE_ESR] = ESR_FP;
> break;
> case POWERPC_EXCP_INVAL:
> - LOG_EXCP("Invalid instruction at " TARGET_FMT_lx "\n", env->nip);
I don't think we want to remove a such important log. Since it make
sense to not disturb the console, maybe we can replace some of the
LOG_EXCP() calls by qemu_log_mask(LOG_GUEST_ERROR,...) instead?
> msr |= 0x00080000;
> env->spr[SPR_BOOKE_ESR] = ESR_PIL;
> break;
>
next prev parent reply other threads:[~2019-12-15 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 12:13 [PATCH] ppc: remove excessive logging Joakim Tjernlund
2019-12-14 22:51 ` no-reply
2019-12-15 5:08 ` Philippe Mathieu-Daudé [this message]
2019-12-15 10:59 ` BALATON Zoltan
2019-12-15 21:15 ` Joakim Tjernlund
2019-12-16 8:27 ` Thomas Huth
2019-12-16 8:39 ` david
2019-12-16 8:52 ` Joakim Tjernlund
2019-12-17 0:31 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a608af2-62a2-3ffb-0c02-8e0ca699d586@redhat.com \
--to=philmd@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=joakim.tjernlund@infinera.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).