From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs
Date: Thu, 15 Oct 2020 20:42:44 +0100 [thread overview]
Message-ID: <4b25afd1-0ce5-0832-a3f0-1b58b3aa7b32@ilande.co.uk> (raw)
In-Reply-To: <91a24667-5f72-d3d9-8e47-6453268d2b78@eik.bme.hu>
On 13/10/2020 18:05, BALATON Zoltan via wrote:
> Hello,
>
> Not related to this patch but while you're at it could you please take those patches
> that are already reviewed by you from this series as well?
>
> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439
>
> That would help cleaning up my tree and see which patches still need changes. Let me
> know if these need any rebasing and point me to the tree on which I should rebase
> them. Currently they apply to your screamer branch I think.
I've queued the grackle/uninorth patches to my qemu-macppc branch, however when I try
to apply patches from the above series git fails with the following message:
Applying: mac_oldworld: Drop a variable, use get_system_memory() directly
error: sha1 information is lacking or useless (hw/ppc/mac_oldworld.c).
error: could not build fake ancestor
Any chance you can rebase and repost? I'm happy to take patches 3 and 4, and if my
suggestion of casting the return address via target_ulong works then I think 1 and 2
are also fine. The I2C stuff I can't really review, and weren't there still issues
with the SPD data in patch 8 reporting the wrong RAM size?
ATB,
Mark.
next prev parent reply other threads:[~2020-10-15 19:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 11:49 [PATCH v2 0/3] ppc: Mac machine updates Mark Cave-Ayland
2020-10-13 11:49 ` [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device Mark Cave-Ayland
2020-10-16 0:16 ` David Gibson
2020-10-16 7:00 ` Mark Cave-Ayland
2020-10-17 6:21 ` David Gibson
2020-10-13 11:49 ` [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs Mark Cave-Ayland
2020-10-13 13:37 ` Philippe Mathieu-Daudé
2020-10-13 16:51 ` Mark Cave-Ayland
2020-10-13 17:05 ` BALATON Zoltan via
2020-10-15 19:42 ` Mark Cave-Ayland [this message]
2020-10-16 0:26 ` BALATON Zoltan via
2020-10-17 13:03 ` Mark Cave-Ayland
2020-10-16 0:18 ` David Gibson
2020-10-16 6:45 ` Howard Spoelstra
2020-10-16 6:53 ` Mark Cave-Ayland
2020-10-17 6:20 ` David Gibson
2020-10-13 11:49 ` [PATCH v2 3/3] uninorth: " Mark Cave-Ayland
2020-10-13 13:38 ` BALATON Zoltan via
2020-10-13 16:58 ` Mark Cave-Ayland
2020-10-13 17:10 ` BALATON Zoltan via
2020-10-16 0:30 ` David Gibson
2020-10-13 13:39 ` Philippe Mathieu-Daudé
2020-10-16 0:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b25afd1-0ce5-0832-a3f0-1b58b3aa7b32@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).