From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, quintela@redhat.com,
qemu-devel@nongnu.org, dgilbert@redhat.com, stefanha@redhat.com,
den@openvz.org, mreitz@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v2 2/5] migretion/block-dirty-bitmap: refactor init_dirty_bitmap_migration
Date: Fri, 31 Jan 2020 13:28:05 -0600 [thread overview]
Message-ID: <4deacc37-9d13-a9bd-288b-083502446e71@redhat.com> (raw)
In-Reply-To: <20191219085106.22309-3-vsementsov@virtuozzo.com>
On 12/19/19 2:51 AM, Vladimir Sementsov-Ogievskiy wrote:
In the subject: s/migretion/migration/
> Split out handling one bs, it is needed for the following commit, which
> will handle BlockBackends in separate.
s/in separate/separately/
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> migration/block-dirty-bitmap.c | 89 +++++++++++++++++++---------------
> 1 file changed, 49 insertions(+), 40 deletions(-)
>
> +++ b/migration/block-dirty-bitmap.c
> @@ -268,57 +268,66 @@ static void dirty_bitmap_mig_cleanup(void)
>
> - for (bs = bdrv_next_all_states(NULL); bs; bs = bdrv_next_all_states(bs)) {
> - const char *name = bdrv_get_device_or_node_name(bs);
> + if (!bs_name || strcmp(bs_name, "") == 0) {
> + error_report("Found bitmap '%s' in unnamed node %p. It can't "
> + "be migrated", bdrv_dirty_bitmap_name(bitmap), bs);
error_report() generally avoids multiple sentences.
> + return -1;
> + }
>
> - FOR_EACH_DIRTY_BITMAP(bs, bitmap) {
> - if (!bdrv_dirty_bitmap_name(bitmap)) {
> - continue;
> - }
> + if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
> + error_report_err(local_err);
> + return -1;
> + }
>
> - if (!name || strcmp(name, "") == 0) {
> - error_report("Found bitmap '%s' in unnamed node %p. It can't "
> - "be migrated", bdrv_dirty_bitmap_name(bitmap), bs);
But as this was just code motion,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-01-31 19:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 8:51 [PATCH v2 0/5] fix migration with bitmaps and mirror Vladimir Sementsov-Ogievskiy
2019-12-19 8:51 ` [PATCH v2 1/5] block: Mark commit and mirror as filter drivers Vladimir Sementsov-Ogievskiy
2020-01-31 19:23 ` Eric Blake
2020-05-14 18:51 ` Eric Blake
2019-12-19 8:51 ` [PATCH v2 2/5] migretion/block-dirty-bitmap: refactor init_dirty_bitmap_migration Vladimir Sementsov-Ogievskiy
2020-01-31 19:28 ` Eric Blake [this message]
2019-12-19 8:51 ` [PATCH v2 3/5] block/dirty-bitmap: add bdrv_has_named_bitmaps helper Vladimir Sementsov-Ogievskiy
2020-05-14 18:30 ` Eric Blake
2019-12-19 8:51 ` [PATCH v2 4/5] migration/block-dirty-bitmap: fix bitmaps migration during mirror job Vladimir Sementsov-Ogievskiy
2020-05-14 18:52 ` Eric Blake
2019-12-19 8:51 ` [PATCH v2 5/5] iotests: 194: test also migration of dirty bitmap Vladimir Sementsov-Ogievskiy
2019-12-19 10:36 ` [PATCH v2 0/5] fix migration with bitmaps and mirror Peter Krempa
2019-12-19 11:39 ` Vladimir Sementsov-Ogievskiy
2020-04-03 11:02 ` Vladimir Sementsov-Ogievskiy
2020-04-03 11:23 ` Peter Krempa
2020-04-03 11:29 ` Vladimir Sementsov-Ogievskiy
2020-04-03 11:52 ` Vladimir Sementsov-Ogievskiy
2020-04-03 15:05 ` Dr. David Alan Gilbert
2020-04-03 15:34 ` Vladimir Sementsov-Ogievskiy
2020-05-14 18:29 ` Eric Blake
2020-05-15 5:52 ` Vladimir Sementsov-Ogievskiy
2020-05-15 11:15 ` Vladimir Sementsov-Ogievskiy
2020-05-15 17:51 ` Eric Blake
2020-05-15 19:49 ` Vladimir Sementsov-Ogievskiy
2020-01-20 9:04 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4deacc37-9d13-a9bd-288b-083502446e71@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).