From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Andrew Jeffery <andrew@aj.id.au>,
Bin Meng <bin.meng@windriver.com>, Joel Stanley <joel@jms.id.au>,
qemu-block@nongnu.org
Subject: Re: [RFC PATCH 03/10] hw/sd: Move proto_name to SDProto structure
Date: Mon, 28 Jun 2021 09:27:02 +0200 [thread overview]
Message-ID: <4e4c2233-5a55-1370-40db-fdc977f5fdbb@kaod.org> (raw)
In-Reply-To: <20210624142209.1193073-4-f4bug@amsat.org>
On 6/24/21 4:22 PM, Philippe Mathieu-Daudé wrote:
> Introduce a new structure to hold the bus protocol specific
> fields: SDProto. The first field is the protocol name.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/sd/sd.c | 28 ++++++++++++++++++++--------
> 1 file changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d71ec81c22a..a1cc8ab0be8 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -88,6 +88,10 @@ enum SDCardStates {
> sd_disconnect_state,
> };
>
> +typedef struct SDProto {
> + const char *name;
> +} SDProto;
Why not use an Object class ?
C.
> +
> struct SDState {
> DeviceState parent_obj;
>
> @@ -112,6 +116,7 @@ struct SDState {
>
> /* Runtime changeables */
>
> + const SDProto *proto; /* Bus protocol */
> uint32_t mode; /* current card mode, one of SDCardModes */
> int32_t state; /* current card state, one of SDCardStates */
> uint32_t vhs;
> @@ -138,7 +143,6 @@ struct SDState {
> qemu_irq readonly_cb;
> qemu_irq inserted_cb;
> QEMUTimer *ocr_power_timer;
> - const char *proto_name;
> bool enable;
> uint8_t dat_lines;
> bool cmd_line;
> @@ -951,8 +955,8 @@ static bool address_in_range(SDState *sd, const char *desc,
>
> static sd_rsp_type_t sd_invalid_state_for_cmd(SDState *sd, SDRequest req)
> {
> - qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state: %s\n",
> - req.cmd, sd_state_name(sd->state));
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: CMD%i in a wrong state: %s\n",
> + sd->proto->name, req.cmd, sd_state_name(sd->state));
>
> return sd_illegal;
> }
> @@ -966,7 +970,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> * However there is no ACMD55, so we want to trace this particular case.
> */
> if (req.cmd != 55 || sd->expecting_acmd) {
> - trace_sdcard_normal_command(sd->proto_name,
> + trace_sdcard_normal_command(sd->proto->name,
> sd_cmd_name(req.cmd), req.cmd,
> req.arg, sd_state_name(sd->state));
> }
> @@ -1526,7 +1530,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> static sd_rsp_type_t sd_app_command(SDState *sd,
> SDRequest req)
> {
> - trace_sdcard_app_command(sd->proto_name, sd_acmd_name(req.cmd),
> + trace_sdcard_app_command(sd->proto->name, sd_acmd_name(req.cmd),
> req.cmd, req.arg, sd_state_name(sd->state));
> sd->card_status |= APP_CMD;
> switch (req.cmd) {
> @@ -1820,7 +1824,7 @@ void sd_write_byte(SDState *sd, uint8_t value)
> if (sd->card_status & (ADDRESS_ERROR | WP_VIOLATION))
> return;
>
> - trace_sdcard_write_data(sd->proto_name,
> + trace_sdcard_write_data(sd->proto->name,
> sd_acmd_name(sd->current_cmd),
> sd->current_cmd, value);
> switch (sd->current_cmd) {
> @@ -1976,7 +1980,7 @@ uint8_t sd_read_byte(SDState *sd)
>
> io_len = (sd->ocr & (1 << 30)) ? 512 : sd->blk_len;
>
> - trace_sdcard_read_data(sd->proto_name,
> + trace_sdcard_read_data(sd->proto->name,
> sd_acmd_name(sd->current_cmd),
> sd->current_cmd, io_len);
> switch (sd->current_cmd) {
> @@ -2095,6 +2099,14 @@ void sd_enable(SDState *sd, bool enable)
> sd->enable = enable;
> }
>
> +static const SDProto sd_proto_spi = {
> + .name = "SPI",
> +};
> +
> +static const SDProto sd_proto_sd = {
> + .name = "SD",
> +};
> +
> static void sd_instance_init(Object *obj)
> {
> SDState *sd = SD_CARD(obj);
> @@ -2115,7 +2127,7 @@ static void sd_realize(DeviceState *dev, Error **errp)
> SDState *sd = SD_CARD(dev);
> int ret;
>
> - sd->proto_name = sd->spi ? "SPI" : "SD";
> + sd->proto = sd->spi ? &sd_proto_spi : &sd_proto_sd;
>
> switch (sd->spec_version) {
> case SD_PHY_SPECv1_10_VERS
>
next prev parent reply other threads:[~2021-06-28 7:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 14:21 [RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols Philippe Mathieu-Daudé
2021-06-24 14:22 ` [RFC PATCH 01/10] hw/sd: When card is in wrong state, log which state it is Philippe Mathieu-Daudé
2021-06-25 7:27 ` Bin Meng
2021-06-24 14:22 ` [RFC PATCH 02/10] hw/sd: Extract address_in_range() helper, log invalid accesses Philippe Mathieu-Daudé
2021-06-25 7:27 ` Bin Meng
2021-06-24 14:22 ` [RFC PATCH 03/10] hw/sd: Move proto_name to SDProto structure Philippe Mathieu-Daudé
2021-06-25 7:27 ` Bin Meng
2021-06-28 7:27 ` Cédric Le Goater [this message]
2021-06-24 14:22 ` [RFC PATCH 04/10] hw/sd: Introduce sd_cmd_handler type Philippe Mathieu-Daudé
2021-06-25 13:46 ` Bin Meng
2021-06-28 7:29 ` Cédric Le Goater
2021-06-28 11:25 ` Philippe Mathieu-Daudé
2021-06-24 14:22 ` [RFC PATCH 05/10] hw/sd: Add sd_cmd_illegal() handler Philippe Mathieu-Daudé
2021-06-25 13:47 ` Bin Meng
2021-06-26 9:48 ` Philippe Mathieu-Daudé
2021-06-28 7:31 ` Cédric Le Goater
2021-06-24 14:22 ` [RFC PATCH 06/10] hw/sd: Add sd_cmd_unimplemented() handler Philippe Mathieu-Daudé
2021-06-25 13:49 ` Bin Meng
2021-06-25 17:17 ` Philippe Mathieu-Daudé
2021-06-26 3:31 ` Bin Meng
2021-06-26 9:43 ` Philippe Mathieu-Daudé
2021-06-24 14:22 ` [RFC PATCH 07/10] hw/sd: Add sd_cmd_GO_IDLE_STATE() handler Philippe Mathieu-Daudé
2021-06-25 13:49 ` Bin Meng
2021-06-24 14:22 ` [RFC PATCH 08/10] hw/sd: Add sd_cmd_SEND_OP_CMD() handler Philippe Mathieu-Daudé
2021-06-24 14:22 ` [RFC PATCH 09/10] hw/sd: Add sd_cmd_ALL_SEND_CID() handler Philippe Mathieu-Daudé
2021-06-25 13:50 ` Bin Meng
2021-06-24 14:22 ` [RFC PATCH 10/10] hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler Philippe Mathieu-Daudé
2021-06-25 13:51 ` Bin Meng
2021-06-28 7:54 ` [RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4c2233-5a55-1370-40db-fdc977f5fdbb@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=bin.meng@windriver.com \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).