From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 009A7C76195 for ; Mon, 27 Mar 2023 19:00:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgs4E-00031K-2N; Mon, 27 Mar 2023 14:59:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgs4C-00030l-8U for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:59:40 -0400 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgs4A-0006pk-Qw for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:59:40 -0400 Received: by mail-oi1-x236.google.com with SMTP id l18so7126796oic.13 for ; Mon, 27 Mar 2023 11:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1679943577; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7tl2B2iyH2iUuOlSLcri0vWQrx8c+SllJ0FaDa1uebk=; b=b23TlYVriKDTGBtOU89ZQImfnWS2XzAlkXTIEEKcZglJDx11y6YPcjkslVLdBCWHzg YWlt+VV79rR3PtWuEc7SlQ3CCjH/Z3CxSfKBaMHz8mAji8zmcdR/RDoGgvdLa4BVgSww SXpEtPzYu7D9PctNZAKNoNXnPvScuaSoBL6nr1O9ishsXVUEYLZsnqQ1H2gURHuNHlAM K6GBqijfs/k8w/MhpM0P6f4j6JdLCkN6z4tqZ1GT5AEPi06GU6AsczuWyOKJffIpU2Nw yQ1r9++Fk3M8Q2s+v0eWI5glWBjB80KigX/duP7EhqmNXglKQU2BDEphOvC0yfE0RsTm l/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679943577; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7tl2B2iyH2iUuOlSLcri0vWQrx8c+SllJ0FaDa1uebk=; b=oJYLtDV1eehNLfLJRKCU0wQYV1FtKDlnUtTLLubDLwJYb3ml2lQ3kKun7YlwsmY4D8 DvIFymhAyFnhXGQpmXkXYGEr65ESuI7uDfbgn2ggR2gEHwdk0l4LXE329dw25KGMtj8e 5FErCVLMIOqtEO2q+j+XWOkxUolaCw7ZIg0oYcPKskBq2/7gJAFtSyqA7BbWfT6R3I7C a6QTItGmJ9dJqBepgOfOP+P0qbWpPmzpP0v3Mz0wweBNT+ea4l//KvJDllhLKv3dfHU2 /92gKRflrZO5hK/UGe6bl4xk49lXDo8etfHeghoZ6O76X2QQYH61qqZFekjIpsZ+7ZlS UtMA== X-Gm-Message-State: AAQBX9d51e72HUZh9gGRCApIWvpSw4F9JWeUCNsGY4bQh/lD6tpfKOAW rIggCkTR829pRoWxqyb9VJ/vmg== X-Google-Smtp-Source: AKy350Z+6hanE4bzpIqy/ZsI4Mo5mwdhmbtvjk2d+0cU2g8tPIgOPrfDy1DKHfnzL2f/u7yukl7BTw== X-Received: by 2002:a05:6808:608f:b0:389:5104:84db with SMTP id de15-20020a056808608f00b00389510484dbmr116536oib.35.1679943577363; Mon, 27 Mar 2023 11:59:37 -0700 (PDT) Received: from [192.168.68.107] ([177.95.89.231]) by smtp.gmail.com with ESMTPSA id i16-20020a544090000000b00387372f548asm6176108oii.16.2023.03.27.11.59.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 11:59:37 -0700 (PDT) Message-ID: <4f2763f2-b008-5dab-2125-ea43a2c98391@ventanamicro.com> Date: Mon, 27 Mar 2023 15:59:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties() Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com References: <20230327124247.106595-1-dbarboza@ventanamicro.com> <20230327124247.106595-4-dbarboza@ventanamicro.com> <8a27b03e-9100-6b64-fde9-6b92a9f643b9@linaro.org> From: Daniel Henrique Barboza In-Reply-To: <8a27b03e-9100-6b64-fde9-6b92a9f643b9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=dbarboza@ventanamicro.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/27/23 15:43, Richard Henderson wrote: > On 3/27/23 05:42, Daniel Henrique Barboza wrote: >> +        g_autofree char *name = g_strdup_printf("%s", misa_cfg->name); >> +        g_autofree char *desc = g_strdup_printf("%s", misa_cfg->description); > > What is the point of this?  It would seem that you could simply pass the original string literals to object_property_*. Yeah, it appears that every other object_property_add() is being called using the literals without dealing with g_autofree. I'll change it in v2. Daniel > > > r~