From: Laurent Vivier <laurent@vivier.eu>
To: Sid Manning <sidneym@quicinc.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: linux-user - time64 question
Date: Wed, 27 May 2020 18:23:11 +0200 [thread overview]
Message-ID: <4f339841-ace9-9499-64f1-6586c9f25690@vivier.eu> (raw)
In-Reply-To: <BYAPR02MB55094915935E2B24286CB519BEA70@BYAPR02MB5509.namprd02.prod.outlook.com>
Le 05/05/2020 à 23:38, Sid Manning a écrit :
> I’m looking at a testcase failure when my target uses 64bit time in
> msg.h (struct msqid_ds). I’ve been able to get around this but changing
> target_msqid_ds like so:
>
>
> @@ -3900,18 +3901,9 @@ static inline abi_long do_semop(int semid,
> abi_long ptr,
> unsigned nsops)
> struct target_msqid_ds
> {
> struct target_ipc_perm msg_perm;
> - abi_ulong msg_stime;
> -#if TARGET_ABI_BITS == 32
> - abi_ulong __unused1;
> -#endif
> - abi_ulong msg_rtime;
> -#if TARGET_ABI_BITS == 32
> - abi_ulong __unused2;
> -#endif
> - abi_ulong msg_ctime;
> -#if TARGET_ABI_BITS == 32
> - abi_ulong __unused3;
> -#endif
> + abi_ullong msg_stime;
> + abi_ullong msg_rtime;
> + abi_ullong msg_ctime;
> abi_ulong __msg_cbytes;
> abi_ulong msg_qnum;
> abi_ulong msg_qbytes;
>
> It seems like either should have worked but I get garbage back in some
> of the elements below msg_time fields without the change.
>
> If time_t is 64bits then it seems like stime/rtime/ctime should be
> abi_ullong.
>
> My target is Hexagon and the TARGET_ABI_BITS is 32.
The structure has been changed into the kernel for the y2038 and the
change has not been reflected into qemu (and it needs).
See kernel commit:
c2ab975c30f0 ("y2038: ipc: Report long times to user space")
Thanks,
Laurent
next prev parent reply other threads:[~2020-05-27 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 21:38 linux-user - time64 question Sid Manning
2020-05-27 16:23 ` Laurent Vivier [this message]
2020-05-27 20:15 ` Sid Manning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f339841-ace9-9499-64f1-6586c9f25690@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).