qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Sam Eiderman <shmuel.eiderman@oracle.com>,
	kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: liran.alon@oracle.com, karl.heubaum@oracle.com, arbel.moshe@oracle.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format
Date: Thu, 20 Jun 2019 15:44:09 +0200	[thread overview]
Message-ID: <4fd4cb44-9e96-4873-b271-4d293838676f@redhat.com> (raw)
In-Reply-To: <20190620091057.47441-1-shmuel.eiderman@oracle.com>


[-- Attachment #1.1: Type: text/plain, Size: 995 bytes --]

On 20.06.19 11:10, Sam Eiderman wrote:
> v1:
> 
> VMware introduced a new snapshot format in VMFS6 - seSparse (Space
> Efficient Sparse) which is the default format available in ESXi 6.7.
> Add read-only support for the new snapshot format.
> 
> v2:
> 
> Fixed after Max's review:
> 
> * Removed strict sesparse checks
> * Reduced maximal L1 table size
> * Added non-write mode check in vmdk_open() on sesparse
> 
> v3:
> 
> Change non-write mode check in vmdk_open() to bdrv_apply_auto_read_only().
> 
> Sam Eiderman (3):
>   vmdk: Fix comment regarding max l1_size coverage
>   vmdk: Reduce the max bound for L1 table size
>   vmdk: Add read-only support for seSparse snapshots
> 
>  block/vmdk.c               | 372 ++++++++++++++++++++++++++++++++++++++++++---
>  tests/qemu-iotests/059.out |   2 +-
>  2 files changed, 353 insertions(+), 21 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2019-06-20 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  9:10 [Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format Sam Eiderman
2019-06-20  9:10 ` [Qemu-devel] [PATCH v3 1/3] vmdk: Fix comment regarding max l1_size coverage Sam Eiderman
2019-06-20  9:10 ` [Qemu-devel] [PATCH v3 2/3] vmdk: Reduce the max bound for L1 table size Sam Eiderman
2019-06-20  9:10 ` [Qemu-devel] [PATCH v3 3/3] vmdk: Add read-only support for seSparse snapshots Sam Eiderman
2019-06-20 13:44 ` Max Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fd4cb44-9e96-4873-b271-4d293838676f@redhat.com \
    --to=mreitz@redhat.com \
    --cc=arbel.moshe@oracle.com \
    --cc=karl.heubaum@oracle.com \
    --cc=kwolf@redhat.com \
    --cc=liran.alon@oracle.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shmuel.eiderman@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).