From: Paolo Bonzini <pbonzini@redhat.com>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "QEMU Developers" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
"Keith Busch" <kbusch@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic
Date: Fri, 8 May 2020 17:33:42 +0200 [thread overview]
Message-ID: <500bd6f3-2b14-eda8-72e5-56c46b7860bd@redhat.com> (raw)
In-Reply-To: <CADSWDzvECqOXzusk=tj8r4z-E5CDZn4TNG8PJ5pxLHAn3saOzA@mail.gmail.com>
On 08/05/20 17:20, Beata Michalska wrote:
>>
>> mr->dirty_log_mask tells if dirty tracking has been enabled, not if the
>> page is dirty. It would always be true during live migration and when
>> running on TCG, but otherwise it would always be false.
>>
>> Beata, can you explain what you had in mind? :)
>>
> It has been a while ... , but the intention there was to skip the sync
> if there is nothing to be synced in the first place - so for performance
> reasons. I honestly do not recall why I went for the dirty_log_mask,
> as that seems not to be the right choice .
You probably wanted to look at the dirty bitmap, but you would have to
define a new bitmap rather than looking at dirty_log_mask.
But that's cool, because it means that we can just remove it! Thanks,
Paolo
next prev parent reply other threads:[~2020-05-08 15:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:24 [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Philippe Mathieu-Daudé
2020-05-08 6:24 ` [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback Philippe Mathieu-Daudé
2020-05-08 20:16 ` Richard Henderson
2020-05-08 6:24 ` [PATCH 2/4] memory: Extract memory_region_msync() from memory_region_writeback() Philippe Mathieu-Daudé
2020-05-08 6:24 ` [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:24 ` [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync() Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:33 ` [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Paolo Bonzini
2020-05-08 15:20 ` Beata Michalska
2020-05-08 15:33 ` Paolo Bonzini [this message]
2020-05-08 15:34 ` Philippe Mathieu-Daudé
2020-05-08 15:35 ` Philippe Mathieu-Daudé
2020-05-08 15:58 ` Paolo Bonzini
2020-05-21 12:32 ` Stefan Hajnoczi
2020-05-21 12:46 ` Paolo Bonzini
2020-05-21 14:21 ` Philippe Mathieu-Daudé
2020-05-27 12:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500bd6f3-2b14-eda8-72e5-56c46b7860bd@redhat.com \
--to=pbonzini@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).