From: Marc Zyngier <maz@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
Julien Thierry <jthierry@redhat.com>,
aik@ozlabs.ru, qemu-devel@nongnu.org, eric.auger@redhat.com,
qemu-arm@nongnu.org, shan.gavin@gmail.com, pbonzini@redhat.com
Subject: Re: [RFC PATCH] hw/arm/virt: Support NMI injection
Date: Thu, 30 Jan 2020 10:58:15 +0000 [thread overview]
Message-ID: <503f32a53fb1a81e2612bcf3eff965da@kernel.org> (raw)
In-Reply-To: <4a517e53-9a7c-903a-9fbc-e1aab1cccefb@redhat.com>
Gavin,
On 2020-01-29 21:54, Gavin Shan wrote:
> On 1/29/20 6:57 PM, Julien Thierry wrote:
>> On 1/29/20 3:46 AM, Gavin Shan wrote:
>>> On 1/28/20 7:29 PM, Julien Thierry wrote:
>
> .../...
>
>>>
>>> Julien, thanks for the explanation. The question we're not sure if
>>> NMI should
>>> be injected on receiving HMP/QMP "nmi" command. It means it's not
>>> clear what
>>> behavior we should have for this command on ARM. However, I have one
>>> more
>>> unrelated question: "pseudo" NMI on ARM64 should be PPI? I mean SPI
>>> can't
>>> be "pseudo" NMI.
>>>
>>
>> I'm not sure I understand why you say "SPI can't be "pseudo" NMI".
>> Currently both PPI and SPI are supported in the "pseudo" NMI scheme.
>> Do you think that should not be the case? If so, can you elaborate?
>>
>> Thanks,
>>
>
> Julien, NMI interrupt is connected to the system by request_nmi() where
> we have
> a check as below. -EINVAL will be returned from request_nmi() on those
> interrupts
> whose descriptors aren't marked with IRQ_NOAUTOEN. SPI falls into this
> category.
The IRQ_NOAUTOEN is set on PPIs because you can't enable them all at
once,
for obvious reasons.
This doesn't mean you cannot set it on other interrupt classes,
including SPIs.
It is actually a fairly common thing to do when you want to decouple
requesting
the interrupt from the enabling, if you do not want the interrupt to be
able to
fire right away.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-01-30 10:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 4:06 [RFC PATCH] hw/arm/virt: Support NMI injection Gavin Shan
2020-01-14 21:50 ` Gavin Shan
2020-01-17 14:00 ` Peter Maydell
2020-01-28 6:48 ` Gavin Shan
2020-01-28 8:05 ` Auger Eric
2020-01-28 9:25 ` Marc Zyngier
2020-01-28 10:56 ` Auger Eric
2020-01-28 10:59 ` Peter Maydell
2020-01-28 11:13 ` Marc Zyngier
2020-01-29 3:30 ` Gavin Shan
2020-01-28 8:29 ` Julien Thierry
2020-01-29 3:46 ` Gavin Shan
2020-01-29 7:57 ` Julien Thierry
2020-01-29 21:54 ` Gavin Shan
2020-01-30 10:58 ` Marc Zyngier [this message]
2020-01-31 6:51 ` Gavin Shan
2020-01-29 2:44 ` Alexey Kardashevskiy
2020-01-29 3:41 ` Gavin Shan
2020-01-29 9:04 ` Marc Zyngier
2020-01-31 6:59 ` Gavin Shan
2020-01-31 9:39 ` Marc Zyngier
2020-02-04 3:51 ` Gavin Shan
2020-02-04 10:22 ` Peter Maydell
2020-02-05 3:09 ` Shan Gavin
2020-02-05 8:07 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503f32a53fb1a81e2612bcf3eff965da@kernel.org \
--to=maz@kernel.org \
--cc=aik@ozlabs.ru \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=jthierry@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).