From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, gleb@redhat.com,
Marcel Apfelbaum <marcel.a@redhat.com>,
hutao@cn.fujitsu.com, qemu-devel@nongnu.org,
Ronen Hod <rhod@redhat.com>,
kraxel@redhat.com, afaerber@suse.de, vrozenfe@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type
Date: Wed, 21 Aug 2013 12:37:46 +0200 [thread overview]
Message-ID: <5214987A.9000107@redhat.com> (raw)
In-Reply-To: <20130821101617.GB4757@redhat.com>
Il 21/08/2013 12:16, Michael S. Tsirkin ha scritto:
> >
> > By the way, this means two things:
> >
> > - I am now sold on the idea that explicitly enabling of pvpanic is the
> > right thing to do;
> >
> > - on the other hand this is the proof that the change was not fully
> > understood, and rushing it in 1.6 was the wrong thing to do.
>
> You mean 1.5.
> pvpanic was a builtin in 1.5 and that was clearly the wrong thing to do.
> We fixed that in 1.6, thankfully.
No, even taking it out in 1.6 is a mistake. It happened too close to
the release.
Now we have 1.5 which has it, 1.6 which doesn't have it and requires
reset after panic, 1.7 which doesn't have it and in all likelihood will
not require reset after panic.
Paolo
next prev parent reply other threads:[~2013-08-21 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 15:10 [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type Marcel Apfelbaum
2013-08-11 15:10 ` [Qemu-devel] [PATCH for-1.6 V2 1/2] hw/misc: don't create pvpanic device by default Marcel Apfelbaum
2013-08-12 3:06 ` Hu Tao
2013-08-12 15:59 ` Andreas Färber
2013-08-13 11:26 ` Markus Armbruster
2013-08-11 15:10 ` [Qemu-devel] [PATCH for-1.6 V2 2/2] hw/misc: make pvpanic known to user Marcel Apfelbaum
2013-08-12 3:07 ` Hu Tao
2013-08-12 15:53 ` [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type Eric Blake
2013-08-12 16:26 ` Marcel Apfelbaum
2013-08-14 7:02 ` Ronen Hod
2013-08-21 8:03 ` Marcel Apfelbaum
2013-08-21 8:18 ` Paolo Bonzini
2013-08-21 9:42 ` Michael S. Tsirkin
2013-08-21 9:56 ` Hu Tao
2013-08-21 9:59 ` Paolo Bonzini
2013-08-21 10:16 ` Michael S. Tsirkin
2013-08-21 10:37 ` Paolo Bonzini [this message]
2013-08-14 16:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214987A.9000107@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=gleb@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).