From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC5oI-00006w-7G
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:38:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC5oC-0002gI-8g
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:38:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5927)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC5oC-0002eJ-1d
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:38:36 -0400
Message-ID: <5214987A.9000107@redhat.com>
Date: Wed, 21 Aug 2013 12:37:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1376233843-19410-1-git-send-email-marcel.a@redhat.com>
	<520B2B8D.8070401@redhat.com>
	<1377072197.1888.35.camel@localhost.localdomain>
	<521477CF.4010703@redhat.com> <20130821094237.GA4757@redhat.com>
	<52148F88.5000509@redhat.com> <20130821101617.GB4757@redhat.com>
In-Reply-To: <20130821101617.GB4757@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic
 from machine type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, gleb@redhat.com, Marcel Apfelbaum <marcel.a@redhat.com>, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, Ronen Hod <rhod@redhat.com>, kraxel@redhat.com, afaerber@suse.de, vrozenfe@redhat.com

Il 21/08/2013 12:16, Michael S. Tsirkin ha scritto:
> > 
> > By the way, this means two things:
> > 
> > - I am now sold on the idea that explicitly enabling of pvpanic is the
> > right thing to do;
> > 
> > - on the other hand this is the proof that the change was not fully
> > understood, and rushing it in 1.6 was the wrong thing to do.
> 
> You mean 1.5.
> pvpanic was a builtin in 1.5 and that was clearly the wrong thing to do.
> We fixed that in 1.6, thankfully.

No, even taking it out in 1.6 is a mistake.  It happened too close to
the release.

Now we have 1.5 which has it, 1.6 which doesn't have it and requires
reset after panic, 1.7 which doesn't have it and in all likelihood will
not require reset after panic.

Paolo