Re: [PATCH] tests/acceptance: Add a boot test for the xlnx-versal-virt machine

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 5/25/20 9:26 AM, Thomas Huth wrote:
> As described by Edgar here:
> 
>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg605124.html
> 
> we can use the Ubuntu kernel for testing the xlnx-versal-virt machine.
> So let's add a boot test for this now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/acceptance/boot_linux_console.py | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 0653c8c1bf..430a6c3b43 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -307,6 +307,30 @@ class BootLinuxConsole(Test):
>          console_pattern = 'Kernel command line: %s' % kernel_command_line
>          self.wait_for_console_pattern(console_pattern)
>  
> +    def test_aarch64_xlnx_versal_virt(self):
> +        """
> +        :avocado: tags=arch:aarch64
> +        :avocado: tags=machine:xlnx-versal-virt

Thanks for adding this test!

Please also add:

           :avocado: tags=device:pl011
           :avocado: tags=device:arm_gicv3

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +        """
> +        kernel_url = ('http://ports.ubuntu.com/ubuntu-ports/dists/'
> +                      'bionic-updates/main/installer-arm64/current/images/'
> +                      'netboot/ubuntu-installer/arm64/linux')
> +        kernel_hash = '5bfc54cf7ed8157d93f6e5b0241e727b6dc22c50'
> +        kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
> +
> +        initrd_url = ('http://ports.ubuntu.com/ubuntu-ports/dists/'
> +                      'bionic-updates/main/installer-arm64/current/images/'
> +                      'netboot/ubuntu-installer/arm64/initrd.gz')
> +        initrd_hash = 'd385d3e88d53e2004c5d43cbe668b458a094f772'
> +        initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash)
> +
> +        self.vm.set_console()
> +        self.vm.add_args('-m', '2G',
> +                         '-kernel', kernel_path,
> +                         '-initrd', initrd_path)
> +        self.vm.launch()
> +        self.wait_for_console_pattern('Checked W+X mappings: passed')
> +
>      def test_arm_virt(self):
>          """
>          :avocado: tags=arch:arm
>