qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Greg Kurz" <groug@kaod.org>
Subject: Re: [PULL v3 2/6] tests/9pfs: change qtest name prefix to synth
Date: Tue, 20 Oct 2020 11:43:18 +0200	[thread overview]
Message-ID: <5436271.QZMOO6KbSo@silver> (raw)
In-Reply-To: <26d3b93c-5dbd-a58c-19e7-060120cfa326@redhat.com>

On Dienstag, 20. Oktober 2020 09:36:10 CEST Philippe Mathieu-Daudé wrote:
> On 10/8/20 8:34 PM, Christian Schoenebeck wrote:
> > All existing 9pfs test cases are using the 'synth' fs driver so far, which
> > means they are not accessing real files, but a purely simulated (in RAM
> > only) file system.
> > 
> > Let's make this clear by changing the prefix of the individual qtest case
> > names from 'fs/' to 'synth/'. That way they'll be easily distinguishable
> > from upcoming new 9pfs test cases supposed to be using a different fs
> > driver.
> > 
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > Message-Id:
> > <e04e75acb849b085c6d6320b2433a15fa935bcff.1602182956.git.qemu_oss@crudeby
> > te.com> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> 
> Harmless, but don't need to sign twice ;)

Ah, I thought that's the common way, as Greg's PRs contained 2 SOBs as well, 
i.e. I thought this was intended to outline the patch author and submaintainer 
were the same person.

BTW I actually did not explicitly add the 2nd SOB. It was rather added by the 
patchwork client automatically. So maybe it should be fixed in the client to 
detect an already existing SOB line? Or am missing something here?

Best regards,
Christian Schoenebeck




  reply	other threads:[~2020-10-20  9:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 12:39 [PULL v3 0/6] 9p queue (previous 2020-10-17) Christian Schoenebeck
2020-10-08 18:34 ` [PULL v3 4/6] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-08 18:34 ` [PULL v3 2/6] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
2020-10-20  7:36   ` Philippe Mathieu-Daudé
2020-10-20  9:43     ` Christian Schoenebeck [this message]
2020-10-20 10:00       ` Greg Kurz
2020-10-20 11:54         ` Christian Schoenebeck
2020-10-21  6:15           ` Philippe Mathieu-Daudé
2020-10-21 10:45             ` Christian Schoenebeck
2020-10-08 18:34 ` [PULL v3 5/6] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-08 18:34 ` [PULL v3 6/6] tests/9pfs: add local Tmkdir test Christian Schoenebeck
2020-10-08 18:34 ` [PULL v3 3/6] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-29 18:02   ` Greg Kurz
2020-10-29 18:16     ` Christian Schoenebeck
2020-10-19 11:10 ` [PULL v3 1/6] 9pfs: suppress performance warnings on qtest runs Christian Schoenebeck
2020-10-19 15:00 ` [PULL v3 0/6] 9p queue (previous 2020-10-17) Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5436271.QZMOO6KbSo@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).