From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Oksana Vohchana <ovoshcha@redhat.com>, qemu-devel@nongnu.org
Cc: wainersm@redhat.com, crosa@redhat.com
Subject: Re: [PATCH v1 2/4] Acceptance test: EXEC migration
Date: Fri, 14 Feb 2020 19:27:10 +0100 [thread overview]
Message-ID: <545474c0-1b28-e830-2601-76a8cbb604b4@redhat.com> (raw)
In-Reply-To: <20200214145235.4378-3-ovoshcha@redhat.com>
On 2/14/20 3:52 PM, Oksana Vohchana wrote:
> Improves EXEC migration to run whole test stage
>
> Signed-off-by: Oksana Vohchana <ovoshcha@redhat.com>
Fixes: 2e768cb682bf
> ---
> tests/acceptance/migration.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
> index e4c39b85a1..8209dcf71d 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -75,3 +75,5 @@ class Migration(Test):
> """
> free_port = self._get_free_port()
> dest_uri = 'exec:nc -l localhost %u' % free_port
> + src_uri = 'exec:nc localhost %u' % free_port
> + self.do_migrate(dest_uri, src_uri)
>
I was very surprised because commit 2e768cb682bf is not the content I
reviewed. Apparently what happened here is you sent 2 different series
with the same subject... I got confused while applying I selected the
incorrect id:
$ pwclient list 'Acceptance test: provides to use different transport
for migration'
ID State Name
-- ----- ----
11348377 New Acceptance test: provides to use different
transport for migration
11348719 New Acceptance test: provides to use different
transport for migration
11355797 New [v2] Acceptance test: provides to use different
transport for migration
11358447 New [v2,REPOST] Acceptance test: provides to use
different transport for migration
11362397 New [v3,1/2] Acceptance test: provides to use
different transport for migration
11362399 New [v3,2/2] Acceptance test: provides to use
different transport for migration
11362479 New [v3,1/2] Acceptance test: provides to use
different transport for migration
11362485 New [v3,2/2] Acceptance test: provides to use
different transport for migration
I am sorry I missed that.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-02-14 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 14:52 [PATCH v1 0/4] Extension of migration tests Oksana Vohchana
2020-02-14 14:52 ` [PATCH v1 1/4] Acceptance test: add address as param Oksana Vohchana
2020-02-20 18:54 ` Wainer dos Santos Moschetta
2020-02-14 14:52 ` [PATCH v1 2/4] Acceptance test: EXEC migration Oksana Vohchana
2020-02-14 18:27 ` Philippe Mathieu-Daudé [this message]
2020-02-20 17:23 ` Wainer dos Santos Moschetta
2020-02-14 14:52 ` [PATCH v1 3/4] Acceptance test: provides new functions Oksana Vohchana
2020-02-21 18:31 ` Wainer dos Santos Moschetta
2020-02-24 16:23 ` Oksana Voshchana
2020-02-14 14:52 ` [PATCH v1 4/4] Acceptance test: provides to use RDMA transport for migration Oksana Vohchana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545474c0-1b28-e830-2601-76a8cbb604b4@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ovoshcha@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).