From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39858)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZDBXY-00046V-VR
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZDBXV-00023X-ER
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:07:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZDBXV-00023R-8b
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:06:57 -0400
References: <1436429849-18052-1-git-send-email-rth@twiddle.net>
	<1436429849-18052-5-git-send-email-rth@twiddle.net>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559E71ED.4030406@redhat.com>
Date: Thu, 9 Jul 2015 15:06:53 +0200
MIME-Version: 1.0
In-Reply-To: <1436429849-18052-5-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/14] target-i386: Implement XSAVEOPT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com



On 09/07/2015 10:17, Richard Henderson wrote:
> @@ -405,7 +405,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>      },
>      [FEAT_XSAVE] = {
>          .feat_names = cpuid_xsave_feature_name,
> -        .cpuid_eax = 0xd,
> +        .cpuid_eax = CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XGETBV1,

KVM does implements CPUID_XSAVE_XSAVEC though.  Should you set
.tcg_features instead?

Paolo

>          .cpuid_needs_ecx = true, .cpuid_ecx = 1,
>          .cpuid_reg = R_EAX,
>          .tcg_features = 0,