From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDBdD-0007Yq-4v for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDBd9-0004tz-EG for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:12:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDBd9-0004tf-8w for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:12:47 -0400 References: <1436429849-18052-1-git-send-email-rth@twiddle.net> <1436429849-18052-6-git-send-email-rth@twiddle.net> From: Paolo Bonzini Message-ID: <559E734B.3020003@redhat.com> Date: Thu, 9 Jul 2015 15:12:43 +0200 MIME-Version: 1.0 In-Reply-To: <1436429849-18052-6-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/14] target-i386: Enable control registers for MPX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: ehabkost@redhat.com On 09/07/2015 10:17, Richard Henderson wrote: > + /* ??? Vol 1, 16.5.6 Intel MPX and SMM says that IA32_BNDCFGS > + is saved at offset 7ED0. Vol 3, 34.4.1.1, Table 32-2, has > + 7EA0-7ED7 as "reserved". What's this, and what's really > + supposed to happen? */ > x86_stq_phys(cs, sm_state + 0x7ed0, env->efer); The format that QEMU (and KVM) are using is based on AMD's format for the state save area. In my copy of the AMD manual this is Table 10-1. Reserved areas in there are 0xfef0-0xfefb and 0xff04-0xff1f. I definitely should update KVM to save/restore BNDCFGS. Thanks for the heads up! Paolo