From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSJ8-0001JT-8d
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:01:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSJ5-0004W9-39
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:01:14 -0400
Received: from mail-wg0-f42.google.com ([74.125.82.42]:33664)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSJ4-0004UC-SQ
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:01:11 -0400
Received: by wgck11 with SMTP id k11so241558316wgc.0
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2015 00:00:24 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1436429849-18052-1-git-send-email-rth@twiddle.net>
	<1436429849-18052-5-git-send-email-rth@twiddle.net>
	<559E71ED.4030406@redhat.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <559F6D72.7030005@twiddle.net>
Date: Fri, 10 Jul 2015 08:00:02 +0100
MIME-Version: 1.0
In-Reply-To: <559E71ED.4030406@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/14] target-i386: Implement XSAVEOPT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com

On 07/09/2015 02:06 PM, Paolo Bonzini wrote:
>
>
> On 09/07/2015 10:17, Richard Henderson wrote:
>> @@ -405,7 +405,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>>       },
>>       [FEAT_XSAVE] = {
>>           .feat_names = cpuid_xsave_feature_name,
>> -        .cpuid_eax = 0xd,
>> +        .cpuid_eax = CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XGETBV1,
>
> KVM does implements CPUID_XSAVE_XSAVEC though.  Should you set
> .tcg_features instead?

Oops, yes of course -- 0xd is the selector here.


r~