From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message
Date: Fri, 20 Aug 2021 18:59:00 +0200 [thread overview]
Message-ID: <5699e784-f120-25e8-d0c6-b3e53ed0b883@redhat.com> (raw)
In-Reply-To: <20210820184048.4a5294c4@redhat.com>
On 8/20/21 6:40 PM, Igor Mammedov wrote:
> On Fri, 20 Aug 2021 18:00:26 +0200
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> On 8/20/21 5:53 PM, David Hildenbrand wrote:
>>> On 20.08.21 17:52, Philippe Mathieu-Daudé wrote:
>>>> When Linux refuses to overcommit a seriously wild allocation we get:
>>>>
>>>> $ qemu-system-i386 -m 40000000
>>>> qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot
>>>> allocate memory
>>>>
>>>> Slighly improve the error message, displaying the memory size
>>>> requested (in case the user didn't expect unspecified memory size
>>>> unit is in MiB):
>>>>
>>>> $ qemu-system-i386 -m 40000000
>>>> qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
>>>> Cannot allocate memory
>>>>
>>>> Reported-by: Bin Meng <bmeng.cn@gmail.com>
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> ---
>>>> softmmu/physmem.c | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
>>>> index 2e18947598e..2f300a9e79b 100644
>>>> --- a/softmmu/physmem.c
>>>> +++ b/softmmu/physmem.c
>>>> @@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block,
>>>> Error **errp)
>>>>
>>>> &new_block->mr->align,
>>>> shared, noreserve);
>>>> if (!new_block->host) {
>>>> + g_autofree char *size_s =
>>>> size_to_str(new_block->max_length);
>>>> error_setg_errno(errp, errno,
>>>> - "cannot set up guest memory '%s'",
>>>> + "Cannot set up %s of guest memory
>>>> '%s'",
>>>> + size_s,
>>>> memory_region_name(new_block->mr));
>>>> qemu_mutex_unlock_ramlist();
>>>> return;
>>>>
>>>
>>> IIRC, ram blocks might not necessarily be used for guest memory ... or
>>> is my memory wrong?
>>
>> No clue, this error message was already here.
>
> it's not only guest RAM, adding size here is marginal improvement,
> (it won't help much since it's not exact match to CLI which may use suffixes for sizes)
The suffixed size is already converted at this point:
qemu-system-i386 -m 2T
qemu-system-i386: Cannot set up 2 TiB of guest memory 'pc.ram': Cannot
allocate memory
I agree however the size displayed might be less than the size passed
to the '-m' argument.
Anyhow I still see the size displayed in the error message as an
useful hint:
$ qemu-system-i386 -m 64000
qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate
memory
VS:
$ qemu-system-i386 -m 64000
qemu-system-i386: Cannot set up 62.5 GiB of guest memory 'pc.ram':
Cannot allocate memory
>
>>
>> No problem to change s/guest/block/ although.
>>
>
next prev parent reply other threads:[~2021-08-20 16:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 15:52 [PATCH] softmmu/physmem: Improve guest memory allocation failure error message Philippe Mathieu-Daudé
2021-08-20 15:53 ` David Hildenbrand
2021-08-20 16:00 ` Philippe Mathieu-Daudé
2021-08-20 16:40 ` Igor Mammedov
2021-08-20 16:59 ` Philippe Mathieu-Daudé [this message]
2021-08-20 17:13 ` Peter Maydell
2021-08-23 8:38 ` David Hildenbrand
2021-08-23 9:23 ` Peter Maydell
2021-08-23 9:29 ` David Hildenbrand
2021-08-23 10:12 ` Philippe Mathieu-Daudé
2021-08-23 10:24 ` David Hildenbrand
2021-08-23 10:34 ` Philippe Mathieu-Daudé
2021-08-23 19:27 ` David Hildenbrand
2021-08-24 8:37 ` Dr. David Alan Gilbert
2021-08-24 8:53 ` David Hildenbrand
2021-08-24 11:42 ` Igor Mammedov
2021-08-20 20:31 ` Peter Xu
2021-08-21 10:01 ` Bin Meng
2021-08-21 10:41 ` Peter Maydell
2021-08-21 13:32 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5699e784-f120-25e8-d0c6-b3e53ed0b883@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).