From: Wen Congyang <wency@cn.fujitsu.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
Eric Blake <eblake@redhat.com>, Alberto Garcia <berto@igalia.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
Markus Armbruster <armbru@redhat.com>,
qemu block <qemu-block@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/3] qapi: child add/delete support
Date: Mon, 18 Jan 2016 09:17:14 +0800 [thread overview]
Message-ID: <569C3D1A.7030807@cn.fujitsu.com> (raw)
In-Reply-To: <1451035376-7252-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
Ping...
On 12/25/2015 05:22 PM, Changlong Xie wrote:
> If quorum's child is broken, we can use mirror job to replace it.
> But sometimes, the user only need to remove the broken child, and
> add it later when the problem is fixed.
>
> ChangLog:
> v9:
> 1. Rebase to the newest codes
> 2. Remove redundant codes in quorum_add_child() and quorum_del_child()
> 3. Fix typos and in qmp-commands.hx
> v8:
> 1. Rebase to the newest codes
> 2. Address the comments from Eric Blake
> v7:
> 1. Remove the qmp command x-blockdev-change's parameter operation according
> to Kevin's comments.
> 2. Remove the hmp command.
> v6:
> 1. Use a single qmp command x-blockdev-change to replace x-blockdev-child-add
> and x-blockdev-child-delete
> v5:
> 1. Address Eric Blake's comments
> v4:
> 1. drop nbd driver's implementation. We can use human-monitor-command
> to do it.
> 2. Rename the command name.
> v3:
> 1. Don't open BDS in bdrv_add_child(). Use the existing BDS which is
> created by the QMP command blockdev-add.
> 2. The driver NBD can support filename, path, host:port now.
> v2:
> 1. Use bdrv_get_device_or_node_name() instead of new function
> bdrv_get_id_or_node_name()
> 2. Update the error message
> 3. Update the documents in block-core.json
>
> Wen Congyang (3):
> Add new block driver interface to add/delete a BDS's child
> quorum: implement bdrv_add_child() and bdrv_del_child()
> qmp: add monitor command to add/remove a child
>
> block.c | 58 ++++++++++++++++++++--
> block/quorum.c | 122 +++++++++++++++++++++++++++++++++++++++++++++-
> blockdev.c | 54 ++++++++++++++++++++
> include/block/block.h | 9 ++++
> include/block/block_int.h | 5 ++
> qapi/block-core.json | 23 +++++++++
> qmp-commands.hx | 47 ++++++++++++++++++
> 7 files changed, 312 insertions(+), 6 deletions(-)
>
prev parent reply other threads:[~2016-01-18 1:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 9:22 [Qemu-devel] [PATCH v9 0/3] qapi: child add/delete support Changlong Xie
2015-12-25 9:22 ` [Qemu-devel] [PATCH v9 1/3] Add new block driver interface to add/delete a BDS's child Changlong Xie
2015-12-25 9:22 ` [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() Changlong Xie
2016-01-20 15:43 ` Alberto Garcia
2016-01-21 1:54 ` Wen Congyang
2016-01-21 13:05 ` Alberto Garcia
2016-01-21 16:58 ` Eric Blake
2016-01-22 9:42 ` Alberto Garcia
2016-01-22 20:02 ` Dr. David Alan Gilbert
2016-01-25 1:13 ` Wen Congyang
2016-02-08 17:06 ` Alberto Garcia
2016-02-16 6:05 ` Changlong Xie
2015-12-25 9:22 ` [Qemu-devel] [PATCH v9 3/3] qmp: add monitor command to add/remove a child Changlong Xie
2016-02-10 18:02 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-02-15 5:01 ` Changlong Xie
2016-01-18 1:17 ` Wen Congyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569C3D1A.7030807@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).