From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aMgRg-0000O1-BA
	for qemu-devel@nongnu.org; Fri, 22 Jan 2016 13:28:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aMgRb-0003dU-Bx
	for qemu-devel@nongnu.org; Fri, 22 Jan 2016 13:28:28 -0500
Received: from mx2.parallels.com ([199.115.105.18]:51743)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1aMgRb-0003dQ-5X
	for qemu-devel@nongnu.org; Fri, 22 Jan 2016 13:28:23 -0500
References: <1453482459-80179-1-git-send-email-vsementsov@virtuozzo.com>
	<1453482459-80179-2-git-send-email-vsementsov@virtuozzo.com>
	<56A26565.9080601@virtuozzo.com> <56A266D3.1030605@virtuozzo.com>
From: "Denis V. Lunev" <den@virtuozzo.com>
Message-ID: <56A274BE.9010504@virtuozzo.com>
Date: Fri, 22 Jan 2016 21:28:14 +0300
MIME-Version: 1.0
In-Reply-To: <56A266D3.1030605@virtuozzo.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-devel@nongnu.org
Cc: famz@redhat.com, jsnow@redhat.com

On 01/22/2016 08:28 PM, Vladimir Sementsov-Ogievskiy wrote:
> On 22.01.2016 20:22, Denis V. Lunev wrote:
>> On 01/22/2016 08:07 PM, Vladimir Sementsov-Ogievskiy wrote:
>>   { 'command': 'query-block', 'returns': ['BlockInfo'] }
>>   +##
>> +# @BlockDirtyRegion:
>> +#
>> +# Region in bytes.
>> +#
>> +# @start: first byte
>> +#
>> +# @count: number of bytes in the region
>> +#
>> +# Since: 2.3
>> +##
>> +{ 'struct': 'BlockDirtyRegion',
>> +  'data': { 'start': 'int', 'count': 'int' } }
>> +
>> +##
>> +# @BlockDirtyBitmapInfo
>> +#
>> +# @name: the name of the dirty bitmap
>> +#
>> +# @size: size of the dirty bitmap in sectors
>> +#
>> +# @granularity: granularity of the dirty bitmap in bytes
>> +#
>> +# @disabled: whether the dirty bitmap is disabled
>> +#
>> +# @dirty-count: number of dirty bytes according to the dirty bitmap
>> +#
>> +# @dirty-regions: dirty regions of the bitmap
>> +#
>> +# Since 2.3
>> +##
>> +{ 'struct': 'BlockDirtyBitmapInfo',
>> +  'data': { 'name': 'str',
>> +            'size': 'int',
>> +            'granularity': 'int',
>> +            'disabled': 'bool',
>> +            'dirty-count': 'int',
>> +            'dirty-regions': ['BlockDirtyRegion'] } }
>> +
>> +##
>> +# @query-block-dirty-bitmap
>> +#
>> +# Get a description for specified dirty bitmap including it's dirty 
>> regions.
>> +# This command is in general for testing purposes.
>> +#
>> +# Returns: @BlockDirtyBitmapInfo
>> +#
>> +# Since: 2.3
>> +##
>> +{ 'command': 'query-block-dirty-bitmap',
>> +  'data': 'BlockDirtyBitmap',
>> +  'returns': 'BlockDirtyBitmapInfo' }
>> 1) should we consider part-by-part retrieval? This could be useful 
>> for large discs.
>> 2) Change to since 2.6
>> 3) Do you think that content should be retrieved separately than data?
>
> 3 - what do you mean?
>

sorry, I mean bitmap description separately from bitmap bits aka data