From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Valentin Rakush <valentin.rakush@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com,
asmetanin@virtuozzo.com, den@openvz.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties
Date: Tue, 26 Jan 2016 08:42:03 -0700 [thread overview]
Message-ID: <56A793CB.3030400@redhat.com> (raw)
In-Reply-To: <20160126153538.GN3869@thinpad.lan.raisama.net>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On 01/26/2016 08:35 AM, Eduardo Habkost wrote:
> On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote:
>> This patch adds support for qom-type-prop-list command to list object
>> class properties. A later patch will use this functionality to
>> implement x86_64-cpu properties.
>>
>
> We already have "-device <type>,help", and it uses a completely
> different mechanism for listing properties. There's no reason for
> having two arbitrarily different APIs for listing properties
> returning different results.
And the QMP counterpart of '-device <type>,help' is
'device-list-properties'.
>
> If qmp_device_list_properties() is not enough for you, please
> clarify why, so we can consider improving it.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-26 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 8:24 [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties Valentin Rakush
2016-01-26 15:35 ` Eduardo Habkost
2016-01-26 15:42 ` Eric Blake [this message]
2016-01-26 15:51 ` Daniel P. Berrange
2016-01-26 17:26 ` Eduardo Habkost
2016-01-26 22:19 ` Daniel P. Berrange
2016-01-27 9:53 ` Valentin Rakush
2016-01-27 15:09 ` Eduardo Habkost
2016-01-27 15:23 ` Daniel P. Berrange
2016-01-29 10:03 ` Valentin Rakush
2016-01-29 15:28 ` Eduardo Habkost
2016-01-31 13:40 ` Valentin Rakush
2016-02-02 15:55 ` Eduardo Habkost
2016-02-07 14:52 ` Valentin Rakush
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A793CB.3030400@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=valentin.rakush@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).