From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO7oN-0007H8-Dx for qemu-devel@nongnu.org; Tue, 26 Jan 2016 12:53:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO7oM-0000fC-I6 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 12:53:51 -0500 References: <1453804705-7205-1-git-send-email-famz@redhat.com> <1453804705-7205-4-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <56A7B2A8.5030104@redhat.com> Date: Tue, 26 Jan 2016 10:53:44 -0700 MIME-Version: 1.0 In-Reply-To: <1453804705-7205-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SnP45P3X1xoKh9obNl50JKngxSrpPThtC" Subject: Re: [Qemu-devel] [RFC PATCH 03/16] block: Allow .bdrv_close callback to release dirty bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , mreitz@redhat.com, vsementsov@parallels.com, Stefan Hajnoczi , jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SnP45P3X1xoKh9obNl50JKngxSrpPThtC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2016 03:38 AM, Fam Zheng wrote: > If the driver owns some dirty bitmaps, this assertion will fail. >=20 > The correct place to release them is in bdrv_close, so move the > assertion one line down. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SnP45P3X1xoKh9obNl50JKngxSrpPThtC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWp7KoAAoJEKeha0olJ0NqI+oH/i8BfKjUnF/XbK/O9gsYZIMT b5e8nv7kLwB8P/NzC7rb57+bAhrJhfQLrSOeaeLTjrJNcPhdU6EbQ4kOKImUI7v3 eSGzlpx9AKU0UT8Co9kQ0HRHhi/mfYW4R4smDKCTXJoUi24Q5MLWL7R4Rnr+dKTn rtmOL0O3HZGTJl1c7Lsx7k6l7Va1LashCggPdrm2aHfqtQqjXijj2oMhJs+cpV+v 31ibwCauwqlJFtr5sF7AJt/s+fE6mgJke54fFBDP7pnkPs/NwmDWuNPefH1ffUD9 n2tlToUihmnxpx32nb94q1alshC5Ti2zMlKYPoCeYi5tBYrlxuw/wjn/LyzSqjw= =ltCl -----END PGP SIGNATURE----- --SnP45P3X1xoKh9obNl50JKngxSrpPThtC--