From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS7Ya-000413-AM for qemu-devel@nongnu.org; Sat, 06 Feb 2016 13:26:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS7YZ-0008DV-I5 for qemu-devel@nongnu.org; Sat, 06 Feb 2016 13:26:04 -0500 From: Sergey Fedorov References: <1454683067-16001-1-git-send-email-peter.maydell@linaro.org> <1454683067-16001-4-git-send-email-peter.maydell@linaro.org> Message-ID: <56B63AB4.4020705@gmail.com> Date: Sat, 6 Feb 2016 21:25:56 +0300 MIME-Version: 1.0 In-Reply-To: <1454683067-16001-4-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] target-arm: Fix IL bit reported for Thumb VFP and Neon traps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, patches@linaro.org On 05.02.2016 17:37, Peter Maydell wrote: > All Thumb Neon and VFP instructions are 32 bits, so the IL > bit in the syndrome register should be set. Pass false to the > syn_* function's is_16bit argument rather than s->thumb > so we report the correct IL bit. > > Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov > --- > target-arm/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 10792e8..fa8e22c 100644 > --- a/target-arm/translate.c > +++ b/target-arm/translate.c > @@ -3077,7 +3077,7 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) > */ > if (s->fp_excp_el) { > gen_exception_insn(s, 4, EXCP_UDEF, > - syn_fp_access_trap(1, 0xe, s->thumb), s->fp_excp_el); > + syn_fp_access_trap(1, 0xe, false), s->fp_excp_el); > return 0; > } > > @@ -4399,7 +4399,7 @@ static int disas_neon_ls_insn(DisasContext *s, uint32_t insn) > */ > if (s->fp_excp_el) { > gen_exception_insn(s, 4, EXCP_UDEF, > - syn_fp_access_trap(1, 0xe, s->thumb), s->fp_excp_el); > + syn_fp_access_trap(1, 0xe, false), s->fp_excp_el); > return 0; > } > > @@ -5137,7 +5137,7 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) > */ > if (s->fp_excp_el) { > gen_exception_insn(s, 4, EXCP_UDEF, > - syn_fp_access_trap(1, 0xe, s->thumb), s->fp_excp_el); > + syn_fp_access_trap(1, 0xe, false), s->fp_excp_el); > return 0; > } >