From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Serial telnet console drops incoming characters on git master
Date: Sun, 7 Feb 2016 18:38:56 +0000 [thread overview]
Message-ID: <56B78F40.1060204@ilande.co.uk> (raw)
Hi Daniel,
I found another issue where the latest set of console updates appear to
break -serial telnet on qemu-system-sparc. What I see is that while
incoming serial telnet appears fine, outgoing serial telnet traffic
caused by typing over the serial connection results in every other
character being dropped.
A quick session with git bisect points to the following commit:
commit f2001a7e0555b66d6db25a3ff1801540814045bb
Author: Daniel P. Berrange <berrange@redhat.com>
Date: Tue Jan 19 11:14:30 2016 +0000
char: don't assume telnet initialization will not block
The current code for doing telnet initialization is writing to
a socket without checking the return status. While it is highly
unlikely to be a problem when writing to a bare socket, as the
buffers are large enough to prevent blocking, this cannot be
assumed safe with TLS sockets. So write the telnet initialization
code into a memory buffer and then use an I/O watch to fully
send the data.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1453202071-10289-4-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I can reproduce this with git master as follows (built on Debian Wheezy
x86-64):
'./configure' '--target-list=sparc-softmmu' --enable-trace-backends=stderr
make install
Next download a copy of the SS-20 PROM from
http://home.earthlink.net/~reif/ss20_v2.25_rom and then start QEMU with
the command line below:
./qemu-system-sparc -bios ./ss20_v2.25_rom -M SS-20 -nographic -boot c
-serial telnet:0.0.0.0:3000,server -cpu "TI SuperSparc 60" -m 64
Now telnet to port 3000 and wait for the PROM to boot all the way to the
"ok" prompt. At this point if you type over the telnet connection, you
should see that every alternate character typed is being lost.
ATB,
Mark.
next reply other threads:[~2016-02-07 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 18:38 Mark Cave-Ayland [this message]
2016-02-08 12:11 ` [Qemu-devel] Serial telnet console drops incoming characters on git master Daniel P. Berrange
2016-02-08 13:56 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B78F40.1060204@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).