From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSnpe-0002Hd-L6 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:34:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSnpb-000068-DN for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:34:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSnpb-00005v-8V for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:34:27 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 8F83A8F4F1 for ; Mon, 8 Feb 2016 15:34:26 +0000 (UTC) References: <1452870739-28484-1-git-send-email-pbonzini@redhat.com> <1452870739-28484-6-git-send-email-pbonzini@redhat.com> <20160202145206.GB32084@stefanha-x1.localdomain> <56B0C4E3.5060808@redhat.com> <20160203093444.GB26227@stefanha-x1.localdomain> <56B1CDE6.9070700@redhat.com> <20160205175149.GA797@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <56B8B578.6070208@redhat.com> Date: Mon, 8 Feb 2016 16:34:16 +0100 MIME-Version: 1.0 In-Reply-To: <20160205175149.GA797@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 05/02/2016 18:51, Stefan Hajnoczi wrote: >> Because this is a file descriptor source, there is really no >> difference between the code's behavior, no matter if aio_poll >> starts before or after the event_notifier_set. The test passes >> even if you remove the sleep. >> >> Do you have any suggestion? Just add a comment? > > How about removing the sleep and adding a comment explaining that > the event_notifier_set() could happen either before or during > poll()? Okay. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWuLV0AAoJEL/70l94x66DajUIAIddRKfy4S45hUQmz9XUTbhA cWfq7SWKjRB7FQSTM2rGDgDCvxDA1MejaIgde3GEMYRQcOj3yZgS8oSvDLXR8Eny Y71Ir/kyjbqVEgjnZwN/1g7gULoS/dZCI/rXgjFjxhe3TC9Pwp6Gp6d6+vlnWRWM c0a1xSwXpbnfLthozgz4eHD7d0u77/Ph7WCyU/2VYI09xKnAel+sIELzrFUhOYcc us4/6tYE1YT0ZagpLkVHXdWbJK30d8tqSU+tBCrW6L/Ql8TAUjwbufaYZpCFBBiL lF1Aif4q3Bg3iCohq4gRSf+96gp2GpIowJKqIJg0BpT9Z5XI/xRRzUeIq9eLbMM= =zN4i -----END PGP SIGNATURE-----