From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>
Cc: John Snow <jsnow@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
Date: Mon, 8 Feb 2016 20:56:02 +0100 [thread overview]
Message-ID: <56B8F2D2.707@redhat.com> (raw)
In-Reply-To: <CAFEAcA_kfc5ZDL0cwX3cOPh-zg3NLc4J_K+WeomikF63KYZN-w@mail.gmail.com>
On 08/02/2016 20:15, Peter Maydell wrote:
> That difference from the kernel script's behaviour is deliberate, because
> the attempt to list recent contributors tends to list a whole lot of
> irrelevant people. So if there's a documented maintainer we prefer to
> just list them, and not all the random other people looking at the git
> logs drags up. Commit c6561586f0f8586 is where we changed the behaviour
> of get_maintainer.pl and the commit message has some rationale.
It should be enough not to check @list_to in the line that commit
c6561586f0f8586 adds:
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7dacf32..f2ee9d8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -636,7 +636,7 @@ sub get_maintainers {
if ($email) {
if (! $interactive) {
- $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame;
+ $email_git_fallback = 0 if @email_to > 0 || $email_git || $email_git_blame;
if ($email_git_fallback) {
print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n";
print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n";
I think this makes sense.
Paolo
prev parent reply other threads:[~2016-02-08 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 17:22 [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ Stephen Warren
2016-02-08 9:05 ` Markus Armbruster
2016-02-08 18:52 ` John Snow
2016-02-08 19:04 ` Stephen Warren
2016-02-08 19:15 ` Peter Maydell
2016-02-08 19:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8F2D2.707@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).