On 02/08/2016 11:49 AM, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > This deals with every .c file in tests/ except those > in tests/tcg which I think are all standalone programs > targeting the guest. > --- > 122 files changed, 122 insertions(+), 202 deletions(-) You may want to wait for other maintainers to chime in for files they care about; but I looked through the patch and nothing jumped out at me as being incorrect. Many of the files already includes libqtest.c or even osdep.h - for those files, the change is obviously correct. Reviewed-by: Eric Blake Tested-by: Eric Blake > +++ b/tests/multiboot/libc.c > @@ -20,6 +20,7 @@ > * THE SOFTWARE. > */ > > +#include "qemu/osdep.h" > #include "libc.h" > > void* memcpy(void *dest, const void *src, int n) Not so sure about this directory. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org