From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsmk-0002Hc-H5 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 15:51:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSsmh-0002Cm-BU for qemu-devel@nongnu.org; Mon, 08 Feb 2016 15:51:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsmh-0002Cf-59 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 15:51:47 -0500 References: <1454957357-22094-1-git-send-email-peter.maydell@linaro.org> <1454957357-22094-3-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <56B8FFE1.60206@redhat.com> Date: Mon, 8 Feb 2016 13:51:45 -0700 MIME-Version: 1.0 In-Reply-To: <1454957357-22094-3-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2AbsU7So44B0Ugj2MM193cFdD4nVVsXlX" Subject: Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Markus Armbruster , patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2AbsU7So44B0Ugj2MM193cFdD4nVVsXlX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/08/2016 11:49 AM, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. >=20 > This commit was created with scripts/clean-includes. >=20 > Signed-off-by: Peter Maydell > --- > This deals with every .c file in tests/ except those > in tests/tcg which I think are all standalone programs > targeting the guest. > --- > 122 files changed, 122 insertions(+), 202 deletions(-) You may want to wait for other maintainers to chime in for files they care about; but I looked through the patch and nothing jumped out at me as being incorrect. Many of the files already includes libqtest.c or even osdep.h - for those files, the change is obviously correct. Reviewed-by: Eric Blake Tested-by: Eric Blake > +++ b/tests/multiboot/libc.c > @@ -20,6 +20,7 @@ > * THE SOFTWARE. > */ > =20 > +#include "qemu/osdep.h" > #include "libc.h" > =20 > void* memcpy(void *dest, const void *src, int n) Not so sure about this directory. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2AbsU7So44B0Ugj2MM193cFdD4nVVsXlX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWuP/hAAoJEKeha0olJ0NqFf8IAIpJ5Ba+X+cxUrwqIwk1Yxpj t/Feejnbdgmsoj1otErVI+3kRy3Smpm3R/RrHqtA59xuAdX+p1gxa7XjkMroSNER 47j71GukRg6t3RG55VY9X9/qLPyvsKRzX1lj1MorxlIaNOI4pd0UpFZ2D4lns978 aS3DL/dsPwODWBlYHdOPRb0GHitAB83OdSjpNAQggzzbniVh04oMKjx230MJNpNd PanJm5F9gTDiXj+nVuYJsyHRbdFF5fYFNQP8tE0f7crzbAY//qcWTff8XqiVUExI Ic+V8nXVte81V0nA4YcyrM57+gL8VvvRMTyx8em86m9vRG+DVdxELuBaI903Q/0= =lAH5 -----END PGP SIGNATURE----- --2AbsU7So44B0Ugj2MM193cFdD4nVVsXlX--