From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aStcD-0004ST-Bh
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 16:45:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aStcA-00077C-4W
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 16:45:01 -0500
Received: from s16892447.onlinehome-server.info ([82.165.15.123]:51097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aStc9-00076x-Um
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 16:44:58 -0500
References: <56AE260C.9020508@ilande.co.uk>
	<CAFEAcA_syW-_rM3yuOPzXPUB245=xnBJEPFeJn0ghfJbBdM+7Q@mail.gmail.com>
	<56AE2E1B.6030106@ilande.co.uk> <56B85AFC.3070604@redhat.com>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-ID: <56B90C45.3080507@ilande.co.uk>
Date: Mon, 8 Feb 2016 21:44:37 +0000
MIME-Version: 1.0
In-Reply-To: <56B85AFC.3070604@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Strange monitor/stdout issue on
 qemu-system-sparc/qemu-system-ppc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 08/02/16 09:08, Paolo Bonzini wrote:

> On 31/01/2016 16:54, Mark Cave-Ayland wrote:
>> Aha! A quick test here shows that the patch fixes the serial port
>> appearing on stdout and entering the monitor, but I still see the
>> multiple echo problem in the GTK GUI.
> 
> And this should be it; if this fixes all your problems I will submit
> it for inclusion.
> 
> Thanks,
> 
> Paolo
> 
> ----------------- 8< ---------------
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] gtk: fix uninitialized temporary VirtualConsole
> 
> Only the echo field is used in the temporary VirtualConsole, so the
> damage was limited.  But still, if echo was incorrectly set to true,
> the result would be some puzzling output in VTE monitor and serial
> consoles.
> 
> Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> diff --git a/ui/gtk.c b/ui/gtk.c
> index c8dbd5c..e106493 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1612,7 +1612,7 @@ static CharDriverState *gd_vc_handler(ChardevVC *vc, Error **errp)
>      chr->chr_set_echo = gd_vc_chr_set_echo;
>  
>      /* Temporary, until gd_vc_vte_init runs.  */
> -    chr->opaque = g_new(VirtualConsole, 1);
> +    chr->opaque = g_new0(VirtualConsole, 1);
>  
>      /* defer OPENED events until our vc is fully initialized */
>      chr->explicit_be_open = true;

Hi Paolo,

Thanks for the patch, I can confirm it fixes the local echo issue for
me. However I still see one more issue in the GTK monitor (I seem to be
doing well here) whereby the width of the GTK console changes size.

With git master, I start up qemu-system-ppc with the GTK interface,
switch to the monitor and type help which gives this output:
https://www.ilande.co.uk/tmp/help1.png. If I then type help again then
the output looks like https://www.ilande.co.uk/tmp/help2.png. In effect,
it looks like the width of the window is 3 characters too wide but only
for the first command.


ATB,

Mark.