From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>,
benh@kernel.crashing.org, agraf@suse.de
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 5/7] pseries: Move hash page table allocation to reset time
Date: Tue, 9 Feb 2016 13:59:06 +1100 [thread overview]
Message-ID: <56B955FA.4050405@ozlabs.ru> (raw)
In-Reply-To: <1454983946-32073-6-git-send-email-david@gibson.dropbear.id.au>
On 02/09/2016 01:12 PM, David Gibson wrote:
> At the moment the size of the hash page table (HPT) is fixed based on the
> maximum memory allowed to the guest. As such, we allocate the table during
> machine construction, and just clear it at reset.
>
> However, we're planning to implement a PAPR extension allowing the hash
> page table to be resized at runtime. This will mean that on reset we want
> to revert it to the default size. It also means that when migrating, we
> need to make sure the destination allocates an HPT of size matching the
> host, since the guest could have changed it before the migration.
>
> This patch replaces the spapr_alloc_htab() and spapr_reset_htab() functions
> with a new spapr_reallocate_hpt() function. This is called at reset and
> inbound migration only, not during machine init any more.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Patch reordering did not help much but "git difftool HEAD^^^ HEAD^^ --
hw/ppc/spapr.c" did :)
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
--
Alexey
next prev parent reply other threads:[~2016-02-09 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 2:12 [Qemu-devel] [PATCHv2 0/7] Cleanups to Hash Page Table handling David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 1/7] target-ppc: Remove unused kvmppc_update_sdr1() stub David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 2/7] target-ppc: Include missing MMU models for SDR1 in info registers David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 3/7] pseries: Simplify handling of the hash page table fd David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 4/7] pseries: Add helper to calculate recommended hash page table size David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 5/7] pseries: Move hash page table allocation to reset time David Gibson
2016-02-09 2:59 ` Alexey Kardashevskiy [this message]
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 6/7] target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM David Gibson
2016-02-09 2:12 ` [Qemu-devel] [PATCHv2 7/7] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT David Gibson
2016-02-11 0:51 ` [Qemu-devel] [PATCHv2 0/7] Cleanups to Hash Page Table handling David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B955FA.4050405@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).