From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56936)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aT6JA-0002Va-Ko
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 06:18:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aT6J5-0006TC-LK
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 06:18:12 -0500
Received: from mx2.parallels.com ([199.115.105.18]:35610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aT6J5-0006Pp-Et
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 06:18:07 -0500
References: <1454514465-11856-1-git-send-email-stefanha@redhat.com>
	<1454514465-11856-6-git-send-email-stefanha@redhat.com>
	<87lh6vvy8k.fsf@linaro.org>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56B9CADB.9030404@openvz.org>
Date: Tue, 9 Feb 2016 14:17:47 +0300
MIME-Version: 1.0
In-Reply-To: <87lh6vvy8k.fsf@linaro.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 05/13] trace: split trace_init_file out of
 trace_init_backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On 02/08/2016 09:43 PM, Alex Bennée wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
>
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> This is cleaner, and improves error reporting with -daemonize.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Message-id: 1452174932-28657-4-git-send-email-den@openvz.org
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>   qemu-io.c       |  2 +-
>>   trace/control.c | 17 ++++++++++++-----
>>   trace/control.h | 13 ++++++++++++-
>>   trace/simple.c  |  6 ++----
>>   trace/simple.h  |  4 ++--
>>   vl.c            | 13 +++++++++----
>>   6 files changed, 38 insertions(+), 17 deletions(-)
>>
>> diff --git a/qemu-io.c b/qemu-io.c
>> index 1c11d57..83c48f4 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -435,7 +435,7 @@ int main(int argc, char **argv)
>>               }
>>               break;
>>           case 'T':
>> -            if (!trace_init_backends(optarg)) {
>> +            if (!trace_init_backends()) {
>>                   exit(1); /* error message will have been printed */
>>               }
>>               break;
>> diff --git a/trace/control.c b/trace/control.c
>> index 931d64c..f5a497a 100644
>> --- a/trace/control.c
>> +++ b/trace/control.c
>> @@ -145,17 +145,24 @@ void trace_init_events(const char *fname)
>>       loc_pop(&loc);
>>   }
>>
>> -bool trace_init_backends(const char *file)
>> +void trace_init_file(const char *file)
>>   {
>>   #ifdef CONFIG_TRACE_SIMPLE
>> -    if (!st_init(file)) {
>> -        fprintf(stderr, "failed to initialize simple tracing backend.\n");
>> -        return false;
>> -    }
>> +    st_set_trace_file(file);
> This breaks "make check" as st_set_trace_file will attempt to flush the
> file:
this does not hang for me even with CONFIG_TRACE_SIMPLE enabled.
Could you share your ./configure options?

Den