From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context
Date: Tue, 9 Feb 2016 08:28:52 -0700 [thread overview]
Message-ID: <56BA05B4.8040603@redhat.com> (raw)
In-Reply-To: <1455012999-26858-2-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
On 02/09/2016 03:16 AM, Denis V. Lunev wrote:
> There is a possibility to hit assert qcow2_get_specific_info that
s/hit assert/hit an assert in/
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that in the qcow2_invalidate_cache closes and the image
> and memsets BDRVQcowState in the middle.
Same grammar suggestions as in 1/2.
>
> The patch moves out processing of bdrv_invalidate_cache_all out of
s/moves out/moves/
> coroutine context for postcopy migration to avoid that. This function
> is called with the following stack:
> process_incoming_migration_co
> qemu_loadvm_state
> qemu_loadvm_state_main
> loadvm_process_command
> loadvm_postcopy_handle_run
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>
> ---
> Actually this patch is compile-tested only. I do not know how to start
> post-copy migration. Previous patch was tested using 'virst managedsave'
Not part of the patch, but s/virst/virsh/
Again, I'll let the migration experts do the actual review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-09 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 10:16 [Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of of coroutine context Denis V. Lunev
2016-02-09 10:16 ` [Qemu-devel] [PATCH 2/2] " Denis V. Lunev
2016-02-09 15:28 ` Eric Blake [this message]
2016-02-09 15:26 ` [Qemu-devel] [PATCH 1/2] " Eric Blake
2016-02-12 6:39 [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out " Denis V. Lunev
2016-02-12 6:39 ` [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-12 12:50 ` Dr. David Alan Gilbert
2016-02-12 12:55 ` Paolo Bonzini
2016-02-12 16:25 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA05B4.8040603@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).