From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTADp-0000Rf-UH for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:28:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTADm-0007fw-Ef for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:28:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTADm-0007ff-9a for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:28:54 -0500 References: <1455012999-26858-1-git-send-email-den@openvz.org> <1455012999-26858-2-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <56BA05B4.8040603@redhat.com> Date: Tue, 9 Feb 2016 08:28:52 -0700 MIME-Version: 1.0 In-Reply-To: <1455012999-26858-2-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gn5ElbJ5esPhDGJ0sCf7cvG2PTdH3gXE4" Subject: Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Amit Shah , Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gn5ElbJ5esPhDGJ0sCf7cvG2PTdH3gXE4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2016 03:16 AM, Denis V. Lunev wrote: > There is a possibility to hit assert qcow2_get_specific_info that s/hit assert/hit an assert in/ > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. >=20 > The problem is that in the qcow2_invalidate_cache closes and the image > and memsets BDRVQcowState in the middle. Same grammar suggestions as in 1/2. >=20 > The patch moves out processing of bdrv_invalidate_cache_all out of s/moves out/moves/ > coroutine context for postcopy migration to avoid that. This function > is called with the following stack: > process_incoming_migration_co > qemu_loadvm_state > qemu_loadvm_state_main > loadvm_process_command > loadvm_postcopy_handle_run >=20 > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > --- > Actually this patch is compile-tested only. I do not know how to start > post-copy migration. Previous patch was tested using 'virst managedsave= ' Not part of the patch, but s/virst/virsh/ Again, I'll let the migration experts do the actual review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Gn5ElbJ5esPhDGJ0sCf7cvG2PTdH3gXE4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWugW1AAoJEKeha0olJ0NqH94IAIxPGCopj5ClZd/DE6D1C6id JjzFMvX/q8BgNNuBeUVKTRNS9HECK9AcBVrzZuj4TiO18APnbMuWLiHMYmhvR9yI UetXvNyjRObDw8KDizDwxHjqTV+Nsa7zYDmULCc7S+04j99eUaaghbsXmh46nmHK 6fUqFJ7IfJkHNZixrVNyG863OK10r3qTzGg2RWqph2KhGJIw0fbxOMfPYv+MwrNf bloqHimE6Uy1U17b7/3CA35GVHBNXFaRqDfW7y77/002g0dUDPDftjtKCuyw6oCy dVPd27TqmZv7tCOCQo+EnscdSA/LaT//SUmsnavtdQWljJSYUG/TcbM6kqvbNx4= =1V1X -----END PGP SIGNATURE----- --Gn5ElbJ5esPhDGJ0sCf7cvG2PTdH3gXE4--