From: Eric Blake <email@example.com> To: Alberto Garcia <firstname.lastname@example.org>, email@example.com Cc: Kevin Wolf <firstname.lastname@example.org>, email@example.com, Max Reitz <firstname.lastname@example.org> Subject: Re: [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del Date: Tue, 9 Feb 2016 08:36:31 -0700 [thread overview] Message-ID: <56BA077F.email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 944 bytes --] On 02/08/2016 07:14 AM, Alberto Garcia wrote: > Now that we allow x-blockdev-del to work in a new scenario that > previously forbidden we must update the iotests in order to reflect > this change. > > Both testAttachMedia() and testSnapshot() are splitted in two: one s/splitted/split/ (one of those weird English words whose past tense is identical to present tense) > version keeps the previous behavior, and a second version checks that > the new functionality works as expected. > > Signed-off-by: Alberto Garcia <email@example.com> > --- > tests/qemu-iotests/139 | 30 +++++++++++++++++++++++++----- > tests/qemu-iotests/139.out | 4 ++-- > 2 files changed, 27 insertions(+), 7 deletions(-) Does the test fail if 1/3 is applied in isolation? If so, then this patch must be squashed with that one. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-09 15:36 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-08 14:14 [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS Alberto Garcia 2016-02-08 14:14 ` [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del Alberto Garcia 2016-02-09 15:36 ` Eric Blake [this message] 2016-02-09 15:44 ` Alberto Garcia 2016-02-08 14:14 ` [Qemu-devel] [PATCH 3/3] block: Update the x-blockdev-del documentation Alberto Garcia 2016-02-09 15:38 ` Eric Blake 2016-02-09 10:32 ` [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS Kevin Wolf 2016-02-09 10:47 ` Alberto Garcia 2016-02-09 15:34 ` Eric Blake 2016-02-09 15:39 ` Alberto Garcia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56BA077F.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).