From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTAYR-0006vQ-Id for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:50:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTAYN-0006LM-BO for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:50:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTAYN-0006L9-5a for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:50:11 -0500 References: <1436429849-18052-1-git-send-email-rth@twiddle.net> <1436429849-18052-6-git-send-email-rth@twiddle.net> <56B9E971.9070509@redhat.com> From: Eric Blake Message-ID: <56BA0AB1.1020207@redhat.com> Date: Tue, 9 Feb 2016 08:50:09 -0700 MIME-Version: 1.0 In-Reply-To: <56B9E971.9070509@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GOJcMUrO3nhKneUkQc4542a71xJJKgSjb" Subject: Re: [Qemu-devel] [PATCH 05/14] target-i386: Enable control registers for MPX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Richard Henderson , qemu-devel@nongnu.org Cc: ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GOJcMUrO3nhKneUkQc4542a71xJJKgSjb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2016 06:28 AM, Paolo Bonzini wrote: > On 09/07/2015 10:17, Richard Henderson wrote: >> + /* Disallow enabling only half of MPX. */ >> + if ((mask ^ (mask * (XSTATE_BNDCSR / XSTATE_BNDREGS))) & XSTATE_B= NDCSR) { >=20 > I'm refreshing patches 1-4 to add PKE support, and this caught my eye..= =2E >=20 > What about just >=20 > if (!!(mask & XSTATE_BNDCSR) !=3D !!(mask & XSTATE_BNDREGS)) Or even: if (!(mask & XSTATE_BNDCSR) !=3D !(mask & XSTATE_BNDREGS)) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GOJcMUrO3nhKneUkQc4542a71xJJKgSjb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWugqxAAoJEKeha0olJ0Nq2nYH/1ClRh6+n3sNlu8dzkMlW+fC IHaxzW+T2UxgDXYm33X116ZGtdl/vpou9Af02bPvxqRnDH8FydDDEQOjjvZBFfZe wNlBHa+EGUjWtZ/1ykoykSY4vpfPC9WxdDS8CyExsj98vWPB3m7OZVwnIkrRyaBc DPVyUNFdKnIEDSkgMeRoc6gSdVDYm7sUD+E15+BSwYQ6TBupXojfRh1WU1HROe/0 se2gG55HUKVNKybZ8o4NWCAkj14Deid3CiRHvRECRE6qJQdlaopVFNEUMV1uImRw GXnIdL6s3I3zhAORaHJLcyqLlFO2L+AhHGKiGCD5B5D2GrDoN5SHJTuyQvoCtLA= =dc1B -----END PGP SIGNATURE----- --GOJcMUrO3nhKneUkQc4542a71xJJKgSjb--