From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 00/14] More #include cleanups
Date: Tue, 9 Feb 2016 10:10:47 -0700 [thread overview]
Message-ID: <56BA1D97.5040705@redhat.com> (raw)
In-Reply-To: <CAFEAcA9zocSxXN2Du29cEEgfg6hFXBauxhN7x+Khu7bddyBnLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]
On 02/09/2016 09:21 AM, Peter Maydell wrote:
> On 9 February 2016 at 16:11, Eric Blake <eblake@redhat.com> wrote:
>> But failed testing:
>>
>> CC disas/arm.o
>> CXX disas/arm-a64.o
>> In file included from /usr/include/c++/5.3.1/cmath:41:0,
>> from /home/eblake/qemu-tmp/disas/libvixl/vixl/utils.h:31,
>> from
>> /home/eblake/qemu-tmp/disas/libvixl/vixl/a64/disasm-a64.h:31,
>> from disas/arm-a64.cc:25:
>> /usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h:1991:10:
>> error: expected unqualified-id before ‘namespace’
>> inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
>> ^
>>
>> Not sure what went wrong there, but 3/14 probably needs tweaking.
>
> Weird. Your machine does compile libvixl right in current master?
> The patch does build fine for me, and it's not clear to me why
> moving the disasm-a64.h include below osdep.h and disas/bfd.h
> would make it stop building. Google suggests that missing
> semicolons can provoke this kind of error so maybe there's
> a latent error in the headers somewhere :-(
Yes, I bisected to 3/14; where things compiled after 1/14 (and 2/14 is
already in-tree).
Looking at the c++config.h header, I see a context of:
#if _GLIBCXX_USE_CXX11_ABI
namespace std
{
inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
}
Comparing pre- and post-patch on the preprocessor output, it used to
expand to:
# 1989 "/usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h" 3
namespace std
{
inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
}
but with the new header order it expands to:
# 1989 "/usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h" 3
namespace std
{
# 1991 "/usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h"
__attribute__ (( always_inline )) __inline__
# 1991 "/usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h" 3
namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
}
So _something_ in osdep.h is redefining 'inline' with disastrous effects
to C++.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-09 17:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:24 [Qemu-devel] [PATCH 00/14] More #include cleanups Peter Maydell
2016-02-09 15:24 ` [Qemu-devel] [PATCH 01/14] cpu: Clean up includes Peter Maydell
2016-02-12 14:49 ` Andreas Färber
2016-02-09 15:24 ` [Qemu-devel] [PATCH 02/14] ui/cocoa.m: Include qemu/osdep.h Peter Maydell
2016-02-09 16:07 ` Eric Blake
2016-02-09 16:08 ` Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 03/14] disas/arm-a64.cc: Include osdep.h first Peter Maydell
2016-02-18 15:49 ` Peter Maydell
2016-02-18 16:41 ` Markus Armbruster
2016-02-18 16:42 ` Peter Maydell
2016-02-18 17:15 ` Eric Blake
2016-02-09 15:25 ` [Qemu-devel] [PATCH 04/14] hw/block/nand.c: " Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 05/14] target-cris: Remove unnecessary ifdef from mmu.c Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 06/14] cris: Clean up includes Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 07/14] libdecnumber: " Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 08/14] tests/i440fx-test: Don't define ARRAY_SIZE locally Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 09/14] tests: Clean up includes Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 10/14] qapi: Clean up includes in generated files Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 11/14] scripts/feature_to_c.sh: Include qemu/osdep.h rather than config.h Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 12/14] scripts/tracetool: Include qemu/osdep.h in generated .c files Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 13/14] all: Clean up includes Peter Maydell
2016-02-09 15:25 ` [Qemu-devel] [PATCH 14/14] oslib-posix.c: Move workaround for OSX daemon() deprecation to osdep.h Peter Maydell
2016-02-09 16:08 ` [Qemu-devel] [PATCH 00/14] More #include cleanups Eric Blake
2016-02-09 16:11 ` Eric Blake
2016-02-09 16:21 ` Peter Maydell
2016-02-09 17:01 ` Peter Maydell
2016-02-09 17:10 ` Eric Blake [this message]
2016-02-09 17:18 ` Eric Blake
2016-02-09 18:04 ` Peter Maydell
2016-02-09 18:17 ` Paolo Bonzini
2016-02-09 18:29 ` Eric Blake
2016-02-16 13:49 ` Peter Maydell
2016-02-16 15:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA1D97.5040705@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).