From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aTBy8-0002qJ-B3
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:20:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aTBy3-0001R8-9g
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:20:52 -0500
Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:36406)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aTBy2-0001QL-8C
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 12:20:46 -0500
Received: by mail-pf0-x244.google.com with SMTP id e127so2744003pfe.3
	for <qemu-devel@nongnu.org>; Tue, 09 Feb 2016 09:20:46 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1455014403-10742-1-git-send-email-rth@twiddle.net>
	<1455014403-10742-12-git-send-email-rth@twiddle.net>
	<20160209165052.GC3678@jhogan-linux.le.imgtec.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56BA1FE6.9000109@twiddle.net>
Date: Wed, 10 Feb 2016 04:20:38 +1100
MIME-Version: 1.0
In-Reply-To: <20160209165052.GC3678@jhogan-linux.le.imgtec.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions
	in tcg_out_movi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 02/10/2016 03:50 AM, James Hogan wrote:
>> +        } else if ((disp & ~(tcg_target_long)0xffff)
>> +                   == sextract32(disp, 16, 16) * 0x10000) {
>> +            tcg_out_opc_imm(s, OPC_ALUIPC, ret, 0, disp >> 16);
>
> I think ret and 0 are the wrong way around here. You're putting 0 in rs
> (the destination register), which causes a seg fault.

Yep, thanks.


r~