qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions in tcg_out_movi
Date: Wed, 10 Feb 2016 04:25:12 +1100	[thread overview]
Message-ID: <56BA20F8.7090908@twiddle.net> (raw)
In-Reply-To: <20160209165052.GC3678@jhogan-linux.le.imgtec.org>

On 02/10/2016 03:50 AM, James Hogan wrote:
> I think ret and 0 are the wrong way around here. You're putting 0 in rs
> (the destination register), which causes a seg fault.
>
> OUT: [size=56]
> 0xfff30b0064:  lw       s1,-8(s0)
> 0xfff30b0068:  bnezalc  zero,s1,0xfff30b0090
> 0xfff30b006c:  nop
> 0xfff30b0070:  j        0xfff0000000
> 0xfff30b0074:  nop
> 0xfff30b0078:  lui      s1,0xbfc0
> 0xfff30b007c:  ori      s1,s1,0x580
> 0xfff30b0080:  sd       s1,256(s0)
> 0xfff30b0084:  aluipc   zero,0xfeb7
> 0xfff30b0088:  j        0xfff30b0034
> 0xfff30b008c:  ori      v0,v0,0x4010
> 0xfff30b0090:  aluipc   zero,0xfeb7
> 0xfff30b0094:  j        0xfff30b0034
> 0xfff30b0098:  ori      v0,v0,0x4013
>
> Cheers
> James
>
>
>
>> +        } else {
>> +            TCGReg in = TCG_REG_ZERO;
>> +            tcg_target_long tmp = (int16_t)arg;
>> +
>> +            /* The R6 manual recommends construction of immediates in
>> +               order of low to high (ADDI, AUI, DAHI, DATI) in order
>> +               to simplify hardware recognizing these sequences.  */
>> +
>> +            if (tmp) {
>> +                tcg_out_opc_imm(s, OPC_ADDIU, ret, in, tmp);
>> +                in = ret;
>> +            }
>> +            arg = (arg - tmp) >> 16;
>> +            tmp = (int16_t)arg;
>> +
>> +            /* Note that DAHI and DATI only have one register operand,
>> +               and are thus we must put a zero low part in place.  Also
>> +               note that we already eliminated simple 32-bit constants
>> +               so we know this must happen.  */
>> +            if (tmp || in != ret) {
>> +                tcg_out_opc_imm(s, OPC_AUI, ret, in, tmp);
>> +            }
>> +            arg = (arg - tmp) >> 16;
>> +            tmp = (int16_t)arg;
>> +
>> +            if (tmp) {
>> +                tcg_out_opc_imm(s, OPC_DAHI, ret, 0, tmp);
>> +            }
>> +            arg = (arg - tmp) >> 16;
>> +            tcg_debug_assert(arg == (int16_t)arg);
>> +
>> +            if (arg) {
>> +                tcg_out_opc_imm(s, OPC_DATI, ret, 0, arg);

Same mistake here for DAHI/DATI.


r~

  parent reply	other threads:[~2016-02-09 17:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 10:39 [Qemu-devel] [PATCH 00/15] tcg mips64 and mipsr6 improvements Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 01/15] tcg-mips: Add mips64 opcodes Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 02/15] tcg-mips: Support 64-bit opcodes Richard Henderson
2016-02-09 15:24   ` James Hogan
2016-02-09 17:16     ` Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 03/15] tcg-mips: Adjust move functions for mips64 Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 04/15] tcg-mips: Adjust load/store " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 05/15] tcg-mips: Adjust prologue " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 06/15] tcg-mips: Add tcg unwind info Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 07/15] tcg-mips: Adjust qemu_ld/st for mips64 Richard Henderson
2016-02-10 16:34   ` James Hogan
2016-02-10 17:35     ` Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 08/15] tcg-mips: Adjust calling conventions " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 09/15] tcg-mips: Fix exit_tb " Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 10/15] tcg-mips: Move bswap code to subroutines Richard Henderson
2016-02-09 10:39 ` [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions in tcg_out_movi Richard Henderson
2016-02-09 16:50   ` James Hogan
2016-02-09 17:20     ` Richard Henderson
2016-02-09 17:25     ` Richard Henderson [this message]
2016-02-10  0:32     ` James Hogan
2016-02-09 10:40 ` [Qemu-devel] [PATCH 12/15] tcg-mips: Use mips64r6 instructions in tcg_out_ldst Richard Henderson
2016-02-09 10:40 ` [Qemu-devel] [PATCH 13/15] tcg-mips: Use mips64r6 instructions in constant addition Richard Henderson
2016-02-09 10:40 ` [Qemu-devel] [PATCH 14/15] tcg-mips: Use mipsr6 instructions in branches Richard Henderson
2016-02-09 16:22   ` James Hogan
2016-02-09 17:13     ` Richard Henderson
2016-02-09 18:46       ` Maciej W. Rozycki
2016-02-10  0:20     ` James Hogan
2016-02-09 10:40 ` [Qemu-devel] [PATCH 15/15] tcg-mips: Use mipsr6 instructions in calls Richard Henderson
2016-02-10 12:49   ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA20F8.7090908@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=james.hogan@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions in tcg_out_movi' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox