From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pasic@linux.vnet.ibm.com>) id 1aTRtQ-0007ZB-LO
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:21:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pasic@linux.vnet.ibm.com>) id 1aTRtM-0008G6-Rj
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:21:04 -0500
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:44642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pasic@linux.vnet.ibm.com>) id 1aTRtM-0008Dh-HU
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 05:21:00 -0500
Received: from localhost
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <pasic@linux.vnet.ibm.com>;
	Wed, 10 Feb 2016 10:20:58 -0000
References: <1455023713-104799-1-git-send-email-silbe@linux.vnet.ibm.com>
	<1455023713-104799-2-git-send-email-silbe@linux.vnet.ibm.com>
From: Halil Pasic <pasic@linux.vnet.ibm.com>
Message-ID: <56BB0F08.7000008@linux.vnet.ibm.com>
Date: Wed, 10 Feb 2016 11:20:56 +0100
MIME-Version: 1.0
In-Reply-To: <1455023713-104799-2-git-send-email-silbe@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by
 typename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: Tu Bo <tubo@linux.vnet.ibm.com>



On 02/09/2016 02:15 PM, Sascha Silbe wrote:
> Sort the alias table by typename so it's easier to see which aliases
> exist.
> 
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> ---
>  qdev-monitor.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 81e3ff3..0145deb 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -40,18 +40,18 @@ typedef struct QDevAlias
>  } QDevAlias;
> 
>  static const QDevAlias qdev_alias_table[] = {
> -    { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -    { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -    { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> +    { "e1000", "e1000-82540em" },
> +    { "ich9-ahci", "ahci" },
> +    { "kvm-pci-assign", "pci-assign" },
> +    { "lsi53c895a", "lsi" },
>      { "virtio-balloon-pci", "virtio-balloon",
>              QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
> +    { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
> +    { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
> -    { "lsi53c895a", "lsi" },
> -    { "ich9-ahci", "ahci" },
> -    { "kvm-pci-assign", "pci-assign" },
> -    { "e1000", "e1000-82540em" },
> +    { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { }
>  };
> 
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>