Re: [Qemu-devel] [PATCH 1/5] target-tricore: Add trap handling

From: Richard Henderson <rth@twiddle.net>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] target-tricore: Add trap handling
Date: Fri, 12 Feb 2016 13:44:17 +1100	[thread overview]
Message-ID: <56BD4701.1060106@twiddle.net> (raw)
In-Reply-To: <1455206520-6465-2-git-send-email-kbastian@mail.uni-paderborn.de>

On 02/12/2016 03:01 AM, Bastian Koppelmann wrote:
> +static inline void
> +generate_trap(DisasContext *ctx, int class, int tin)
> +{
> +    TCGv_i32 classtemp = tcg_const_i32(class);
> +    gen_save_pc(ctx->pc);
> +    /* upper context cannot be saved, if the context list is empty */
> +    if (class != TRAPC_SYSCALL) {
> +        gen_helper_svucx(cpu_env);
> +    }
> +    /* Tin is loaded into d[15] */
> +    tcg_gen_movi_tl(cpu_gpr_d[15], tin);
> +    /* The return address in A[11] is updated. */
> +    if (class == TRAPC_SYSCALL) {
> +        tcg_gen_movi_tl(cpu_gpr_a[11], ctx->next_pc);
> +    } else {
> +        tcg_gen_movi_tl(cpu_gpr_a[11], ctx->pc);
> +    }
> +    gen_helper_raise_exception_err(cpu_env, classtemp, 0);
> +    tcg_temp_free(classtemp);
> +}

Again, drop the inline.  Missing ctx->bstate = BS_EXCP.

r~